Implement Filestore #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ends up serving as a reference of a bunch of sources, from which the library is based on
jmg-duarte
force-pushed
the
feat/23/filestore
branch
from
843a024 to
054ca9b
Compare
jmg-duarte
requested review from
cernicc,
th7nder,
serg-temchenko and
aidan46
as code owners
th7nder
reviewed
Jun 3, 2024
th7nder
added
ready for review
serg-temchenko
suggested changes
Jun 3, 2024
cernicc
reviewed
Jun 4, 2024
th7nder
approved these changes
Jun 4, 2024
th7nder
added
ready for review
serg-temchenko
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23
Adds a file-backed CAR store/importer. It mainly mimics the function of
CreateFilestore.This functionality should be part of the file importing process
https://github.com/filecoin-project/lotus/blob/0a51a0a21933c6db1067b5bb598f4a0fe7b70051/node/impl/client/client.go#L503-L575
Important points for reviewers
Like
Blockstore,Filestoreneeds to be actually used to better shape the API. Everything is working though!Checklist