fix(primitives): extract PreCommitSectorInfo #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmg-duarte
added
bug
jmg-duarte
force-pushed
the
fix/precommit/primitives
branch
from
d4f0c58 to
299dac5
Compare
jmg-duarte
added
ready for review
aidan46
previously approved these changes
Jan 16, 2025
jmg-duarte
added
ready for review
cernicc
approved these changes
Jan 16, 2025
aidan46
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracts the
PreCommitSectorInfoto primitivesWhile working on the benchmarks for pallet-market I noticed that I couldn't import
PreCommitSectorInfo(which is a bug).This extracts the
PreCommitSectorInfoand its builder to primitives, making it generally available.The builder was namespaced under
builderand feature gated.