-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: make prove commit work with maat #684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th7nder
changed the title
refactor: extract pipeline steps
test: make prove commit work with maat
Jan 22, 2025
jmg-duarte
previously approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cernicc
reviewed
Jan 22, 2025
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jan 22, 2025
cernicc
approved these changes
Jan 22, 2025
jmg-duarte
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially fixes #615, #381.
Now maat does not depend on hard-coded values but uses the same logic as the pipeline does.
The PoSt logic will come in a follow-up PR, I don't want to make this a bigger one.
Important points for reviewers
It basically moves the important logic to the
UnsealedSector
,PreCommittedSector
,ProvenSector
types.Those structs become empowered so they can be used in the maat.
Pipeline is just calling them and saving state.
Checklist