fix(primitives): reduce cid feature set #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM compilation of primitives was broken because we didn't depent on alloc. This was not noticeable anywhere else because of cargo's feature unification, when building the pallets, we depended directly on cid with the alloc feature, as such, when primitives was built, it already had the alloc feature.
th7nder
approved these changes
Jan 23, 2025
cernicc
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WASM compilation of primitives was broken because we didn't depent on alloc. This was not noticeable anywhere else because of cargo's feature unification, when building the pallets, we depended directly on cid with the alloc feature, as such, when primitives was built, it already had the alloc feature.
You can double check this by running the following command, before and after the change: