-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/66/polka storage provider print start time of the provider #86
Feat/66/polka storage provider print start time of the provider #86
Conversation
…t-time-of-the-provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could you provide some instructions in the PR how can I run it locally and test it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I struggle to understand some decisions, comments would definitely help, though I still left some questions looking for some insight!
…t-time-of-the-provider
…age-provider-print-start-time-of-the-provider
…age-provider-print-start-time-of-the-provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! The API feels more natural now.
I've left some nitpicks and requests.
A quick note on them so you know where I'm coming from: after suffering a lot with Filecoin's lack of clarity and documentation, I believe we ought to be better and make code more readable without requiring you to already be a developer of the codebase. It helps anyone doing reviews as well as help onboard anyone that joins the project, saving everyone time in the process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job!
…t-time-of-the-provider
Description
Implemented rpc client for the storage provider. The usage can be seen when calling
info
command. The client leverages the existing trait used for defining rpc methods.How to test
Run rpc server:
RUST_LOG=polka_storage_provider=trace cargo run --bin polka-storage-provider -- run --rpc-address ws://127.0.0.1:<parachain_node_port>
Execute cli info command:
RUST_LOG=polka_storage_provider=trace cargo run --bin polka-storage-provider -- info
Checklist