Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pallet-market): verify_deals_for_activation #89

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Jun 20, 2024

Description

Implements verify_deals_for_activation method which is called by Storage Provider Pallet through primitives/proofs/trait and loose coupling to check whether given sector can be activated and won't err on Activation.
This method also computes CommD

Important points for reviewers

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • If there are follow-ups, have you created issues for them?
  • Have you tested this solution?
  • Were there any alternative implementations considered?
    • This function Errs if any deal in any sector is not valid, fails fast. Alternative would be to gather errors, batch them, and return as response. However... this is just not how reference implementation works.
    • Name primitives/proofs and all, are just something, somewhere, not sure it's best, but it works.
  • Did you document new (or modified) APIs?

@th7nder th7nder self-assigned this Jun 20, 2024
@th7nder th7nder force-pushed the feat/11/market-pallet-verify-deals branch 2 times, most recently from 9ea44c4 to 1ee3bd8 Compare June 20, 2024 15:19
@th7nder th7nder linked an issue Jun 20, 2024 that may be closed by this pull request
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
pallets/market/src/lib.rs Outdated Show resolved Hide resolved
@th7nder th7nder force-pushed the feat/11/market-pallet-verify-deals branch from 1ee3bd8 to 6eef4b0 Compare June 21, 2024 11:57
@th7nder th7nder force-pushed the feat/11/market-pallet-publish-storage branch 2 times, most recently from 5673a3b to 5ffa9f4 Compare June 21, 2024 14:51
@th7nder th7nder force-pushed the feat/11/market-pallet-verify-deals branch 6 times, most recently from 6f3d785 to f4fb6e0 Compare June 24, 2024 07:04
@th7nder th7nder marked this pull request as ready for review June 24, 2024 07:07
@th7nder th7nder requested a review from jmg-duarte June 24, 2024 07:08
@th7nder th7nder added the ready for review Review is needed label Jun 24, 2024
@th7nder th7nder force-pushed the feat/11/market-pallet-verify-deals branch from f4fb6e0 to 5d411f5 Compare June 24, 2024 09:12
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jun 24, 2024
@th7nder th7nder force-pushed the feat/11/market-pallet-verify-deals branch from 5d411f5 to 35433c1 Compare June 24, 2024 09:15
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jun 24, 2024
@th7nder th7nder force-pushed the feat/11/market-pallet-verify-deals branch from 35433c1 to fda6c6e Compare June 24, 2024 10:54
@th7nder th7nder removed the ready for review Review is needed label Jun 24, 2024
@th7nder th7nder added the ready for review Review is needed label Jun 24, 2024
Base automatically changed from feat/11/market-pallet-publish-storage to feat/11/market-pallet-setup June 26, 2024 08:35
Base automatically changed from feat/11/market-pallet-setup to develop June 26, 2024 13:24
@th7nder th7nder force-pushed the feat/11/market-pallet-verify-deals branch from fda6c6e to 5ffeec7 Compare June 26, 2024 13:51
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jun 26, 2024
jmg-duarte
jmg-duarte previously approved these changes Jun 27, 2024
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though it could benefit from the comments.

Not blocking merging for those right now though

primitives/proofs/src/traits.rs Outdated Show resolved Hide resolved
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Jun 27, 2024
Copy link
Member

@cernicc cernicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@th7nder th7nder merged commit 92f2d99 into develop Jun 28, 2024
3 checks passed
@th7nder th7nder deleted the feat/11/market-pallet-verify-deals branch June 28, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants