-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pallet-market): verify_deals_for_activation #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th7nder
force-pushed
the
feat/11/market-pallet-verify-deals
branch
2 times, most recently
from
June 20, 2024 15:19
9ea44c4
to
1ee3bd8
Compare
jmg-duarte
reviewed
Jun 20, 2024
th7nder
force-pushed
the
feat/11/market-pallet-verify-deals
branch
from
June 21, 2024 11:57
1ee3bd8
to
6eef4b0
Compare
th7nder
force-pushed
the
feat/11/market-pallet-publish-storage
branch
2 times, most recently
from
June 21, 2024 14:51
5673a3b
to
5ffa9f4
Compare
th7nder
force-pushed
the
feat/11/market-pallet-verify-deals
branch
6 times, most recently
from
June 24, 2024 07:04
6f3d785
to
f4fb6e0
Compare
th7nder
requested review from
cernicc,
serg-temchenko and
aidan46
as code owners
June 24, 2024 07:07
th7nder
force-pushed
the
feat/11/market-pallet-verify-deals
branch
from
June 24, 2024 09:12
f4fb6e0
to
5d411f5
Compare
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jun 24, 2024
th7nder
force-pushed
the
feat/11/market-pallet-verify-deals
branch
from
June 24, 2024 09:15
5d411f5
to
35433c1
Compare
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jun 24, 2024
th7nder
force-pushed
the
feat/11/market-pallet-verify-deals
branch
from
June 24, 2024 10:54
35433c1
to
fda6c6e
Compare
Base automatically changed from
feat/11/market-pallet-publish-storage
to
feat/11/market-pallet-setup
June 26, 2024 08:35
th7nder
force-pushed
the
feat/11/market-pallet-verify-deals
branch
from
June 26, 2024 13:51
fda6c6e
to
5ffeec7
Compare
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jun 26, 2024
aidan46
reviewed
Jun 26, 2024
jmg-duarte
previously approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though it could benefit from the comments.
Not blocking merging for those right now though
th7nder
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
Jun 27, 2024
cernicc
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
jmg-duarte
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements
verify_deals_for_activation
method which is called byStorage Provider Pallet
throughprimitives/proofs/trait
and loose coupling to check whether given sector can be activated and won't err on Activation.This method also computes CommD
Important points for reviewers
Checklist
primitives/proofs
and all, are just something, somewhere, not sure it's best, but it works.