subpath imports for explicit 1:1, concat prefix + suffix scenarios an…

…d conditionals, with fixtures that verify project setup and build result with runtime

.github/workflows/verify.yml

@@ -54,6 +54,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20
       - uses: dtolnay/rust-toolchain@stable
       - uses: swatinem/rust-cache@v2
       - name: cargo test

Cargo.toml

@@ -6,7 +6,7 @@ members = [
 [workspace.dependencies]
 anyhow = "1.0.92"
 serde = { version = "1.0.213", features = ["derive"] }
-serde_json = "1.0.132"
+serde_json = { version = "1.0.132", features = ["preserve_order"] }
 swc = "4.0.0"
 swc_common = { version = "3.0.0", features = ["concurrent"] }
 swc_ecma_ast = "3.0.0"

fn_build/Cargo.toml

@@ -8,14 +8,14 @@ repository = { workspace = true }
 [dependencies]
 anyhow = { workspace = true }
 serde = { workspace = true }
+serde_json = { workspace = true }
 swc = { workspace = true }
 swc_common = { workspace = true }
 swc_ecma_ast = { workspace = true }
 swc_ecma_parser = { workspace = true }
 swc_ecma_visit = { workspace = true }
-thiserror = "1.0.67"
+thiserror = "2.0.0"
 tokio = { workspace = true }
 
 [dev-dependencies]
-serde_json = { workspace = true }
 temp-dir = { workspace = true }

fn_build/fixtures/node/js/http_route/.fixture/build_debug.json

@@ -0,0 +1,12 @@
+{
+  "files": [
+    {
+      "path": "package.json",
+      "result": "identical"
+    },
+    {
+      "path": "routes/data/lambda.js",
+      "result": "identical"
+    }
+  ]
+}

fn_build/fixtures/node/js/http_route/.fixture/build_release.json

@@ -0,0 +1,14 @@
+{
+  "files": [
+    {
+      "path": "package.json",
+      "result": "identical"
+    },
+    {
+      "path": "routes/data/lambda.js",
+      "result": {
+        "content": "export const DELETE=()=>{console.log(\"delete\")};"
+      }
+    }
+  ]
+}

fn_build/fixtures/node/js/http_route/.fixture/parse.json

@@ -0,0 +1,13 @@
+{
+  "dependencies": "unused",
+  "sources": [
+    {
+      "imports": [],
+      "path": "package.json"
+    },
+    {
+      "imports": [],
+      "path": "routes/data/lambda.js"
+    }
+  ]
+}

fn_build/fixtures/node/js/http_route/package.json

@@ -0,0 +1,3 @@
+{
+  "type": "module"
+}

fn_build/fixtures/node/js/relative_import/.fixture/build_debug.json

@@ -0,0 +1,16 @@
+{
+  "files": [
+    {
+      "path": "package.json",
+      "result": "identical"
+    },
+    {
+      "path": "lib/data.js",
+      "result": "identical"
+    },
+    {
+      "path": "routes/data/lambda.js",
+      "result": "identical"
+    }
+  ]
+}

fn_build/fixtures/node/js/relative_import/.fixture/build_release.json

@@ -0,0 +1,20 @@
+{
+  "files": [
+    {
+      "path": "package.json",
+      "result": "identical"
+    },
+    {
+      "path": "lib/data.js",
+      "result": {
+        "content": "let t=[];export function getData(){return t}"
+      }
+    },
+    {
+      "path": "routes/data/lambda.js",
+      "result": {
+        "content": "import{getData as o}from\"../../lib/data.js\";export const GET=()=>{console.log(\"got\",o())};"
+      }
+    }
+  ]
+}

fn_build/fixtures/node/js/relative_import/.fixture/parse.json

@@ -0,0 +1,21 @@
+{
+  "dependencies": "unused",
+  "sources": [
+    {
+      "imports": [],
+      "path": "package.json"
+    },
+    {
+      "imports": [],
+      "path": "lib/data.js"
+    },
+    {
+      "imports": [
+        {
+          "relativeSource": "lib/data.js"
+        }
+      ],
+      "path": "routes/data/lambda.js"
+    }
+  ]
+}

fn_build/fixtures/node/js/relative_import/package.json

@@ -0,0 +1,3 @@
+{
+  "type": "module"
+}

fn_build/fixtures/node/js/subpath_import/conditions/nested/.fixture/build_debug.json

@@ -0,0 +1,12 @@
+{
+  "files": [
+    {
+      "path": "package.json",
+      "result": "identical"
+    },
+    {
+      "path": "routes/data/lambda.js",
+      "result": "identical"
+    }
+  ]
+}

fn_build/fixtures/node/js/subpath_import/conditions/nested/.fixture/build_release.json

@@ -0,0 +1,14 @@
+{
+  "files": [
+    {
+      "path": "package.json",
+      "result": "identical"
+    },
+    {
+      "path": "routes/data/lambda.js",
+      "result": {
+        "content": "import{getData as o}from\"#data\";import{getLog as t}from\"#log\";export const GET=()=>{console[t()](\"got\",o())};"
+      }
+    }
+  ]
+}

fn_build/fixtures/node/js/subpath_import/conditions/nested/.fixture/parse.json

@@ -0,0 +1,26 @@
+{
+  "dependencies": "required",
+  "sources": [
+    {
+      "imports": [],
+      "path": "package.json"
+    },
+    {
+      "imports": [
+        {
+          "packageDependency": {
+            "package": "data-dep",
+            "subpath": null
+          }
+        },
+        {
+          "packageDependency": {
+            "package": "log-dep",
+            "subpath": null
+          }
+        }
+      ],
+      "path": "routes/data/lambda.js"
+    }
+  ]
+}

fn_build/fixtures/node/js/subpath_import/conditions/nested/.fixture/spec.json

@@ -0,0 +1,3 @@
+{
+  "entrypoint": "routes/data/lambda.js"
+}

fn_build/fixtures/node/js/subpath_import/conditions/nested/lib/data-polyfill.js

@@ -0,0 +1,3 @@
+export function getData() {
+    return []
+}

fn_build/fixtures/node/js/subpath_import/conditions/nested/lib/tla-log.js

@@ -0,0 +1,3 @@
+export function getLog() {
+    return 'log'
+}

fn_build/fixtures/node/js/subpath_import/conditions/nested/package.json

@@ -0,0 +1,19 @@
+{
+  "type": "module",
+  "imports": {
+    "#data": {
+      "require": "./lib/data-polyfill.js",
+      "node": {
+        "import": {
+          "node-addons": "data-dep"
+        }
+      }
+    },
+    "#log": {
+      "node": {
+        "require": "./lib/tla-log.js"
+      },
+      "import": "log-dep"
+    }
+  }
+}

fn_build/fixtures/node/js/subpath_import/conditions/nested/routes/data/lambda.js

@@ -0,0 +1,6 @@
+import {getData} from '#data'
+import {getLog} from '#log'
+
+export const GET = () => {
+    console[getLog()]('got', getData())
+}

fn_build/fixtures/node/js/subpath_import/conditions/skips_cjs/.fixture/build_debug.json

@@ -0,0 +1,20 @@
+{
+  "files": [
+    {
+      "path": "package.json",
+      "result": "identical"
+    },
+    {
+      "path": "lib/not-module-sync.js",
+      "result": "identical"
+    },
+    {
+      "path": "lib/not-require.js",
+      "result": "identical"
+    },
+    {
+      "path": "routes/data/lambda.js",
+      "result": "identical"
+    }
+  ]
+}

fn_build/fixtures/node/js/subpath_import/conditions/skips_cjs/.fixture/build_release.json

@@ -0,0 +1,26 @@
+{
+  "files": [
+    {
+      "path": "package.json",
+      "result": "identical"
+    },
+    {
+      "path": "lib/not-module-sync.js",
+      "result": {
+        "content": "export function isModuleSync(){return!1}"
+      }
+    },
+    {
+      "path": "lib/not-require.js",
+      "result": {
+        "content": "export function isRequire(){return!1}"
+      }
+    },
+    {
+      "path": "routes/data/lambda.js",
+      "result": {
+        "content": "import{isModuleSync as o}from\"#not-module-sync\";import{isRequire as r}from\"#not-require\";export const GET=()=>{console.log(o(),r())};"
+      }
+    }
+  ]
+}