chore: improve ux in keybind recording view

closes #360
ejbills · Dec 22, 2024 · 5730d47 · 5730d47
1 parent 75adec7
commit 5730d47
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 2 deletions.
diff --git a/DockDoor/Localizable.xcstrings b/DockDoor/Localizable.xcstrings
@@ -894,6 +894,9 @@
           }
         }
       }
+    },
+    "1. Select \"Command (⌘)\" as the initialization key." : {
+
     },
     "1/%lldx" : {
       "localizations" : {
@@ -1072,6 +1075,15 @@
           }
         }
       }
+    },
+    "2. Click \"Start Recording Trigger Key\"." : {
+
+    },
+    "3. Press ONLY the Tab key (not Command+Tab)." : {
+
+    },
+    "4. Your keybind will be set to Command+Tab." : {
+
     },
     "Accessibility" : {
       "localizations" : {
@@ -9306,6 +9318,9 @@
           }
         }
       }
+    },
+    "Example:" : {
+
     },
     "Exclude windows from capture by filtering specific text in their titles" : {
 
@@ -12709,6 +12724,9 @@
           }
         }
       }
+    },
+    "Important: When recording, press ONLY the trigger key (e.g. just press Tab if you want command + Tab). Do not press the initialization key during recording." : {
+
     },
     "Include Hidden and Minimized Windows in the Window Switcher" : {
       "localizations" : {
@@ -18439,6 +18457,7 @@
       }
     },
     "Press any key to set the keybind." : {
+      "extractionState" : "stale",
       "localizations" : {
         "af" : {
           "stringUnit" : {
@@ -26473,6 +26492,7 @@
       }
     },
     "Start recording keybind" : {
+      "extractionState" : "stale",
       "localizations" : {
         "af" : {
           "stringUnit" : {
@@ -26828,6 +26848,9 @@
           }
         }
       }
+    },
+    "Start recording trigger key" : {
+
     },
     "Subatomic" : {
       "comment" : "Window size option",

diff --git a/DockDoor/Views/Settings/WindowSwitcherSettingsView.swift b/DockDoor/Views/Settings/WindowSwitcherSettingsView.swift
@@ -51,12 +51,12 @@ struct WindowSwitcherSettingsView: View {
                 .scaledToFit()
                 .layoutPriority(1)
 
-                Text("Press any key to set the keybind.")
+                Text("Important: When recording, press ONLY the trigger key (e.g. just press Tab if you want command + Tab). Do not press the initialization key during recording.")
                     .font(.subheadline)
                     .foregroundColor(.secondary)
 
                 Button(action: { viewModel.isRecording.toggle() }) {
-                    Text(viewModel.isRecording ? "Press any key..." : "Start recording keybind")
+                    Text(viewModel.isRecording ? String(localized: "Press any key...") : String(localized: "Start recording trigger key"))
                 }
                 .keyboardShortcut(.defaultAction)
 
@@ -65,6 +65,29 @@ struct WindowSwitcherSettingsView: View {
                         .font(.subheadline)
                         .padding(.top, 5)
                 }
+
+                Divider()
+
+                VStack(alignment: .leading, spacing: 4) {
+                    Text("Example:")
+                        .font(.body)
+
+                    Text("1. Select \"Command (⌘)\" as the initialization key.")
+                        .font(.subheadline)
+                        .foregroundColor(.secondary)
+
+                    Text("2. Click \"Start Recording Trigger Key\".")
+                        .font(.subheadline)
+                        .foregroundColor(.secondary)
+
+                    Text("3. Press ONLY the Tab key (not Command+Tab).")
+                        .font(.subheadline)
+                        .foregroundColor(.secondary)
+
+                    Text("4. Your keybind will be set to Command+Tab.")
+                        .font(.subheadline)
+                        .foregroundColor(.secondary)
+                }
             }
         }
         .padding(20)