Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/sol/refactor ii #391

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Dev/sol/refactor ii #391

merged 3 commits into from
Oct 24, 2023

Conversation

SoloJacobs
Copy link
Contributor

No description provided.

jherbel
jherbel approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jherbel jherbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea 👍 Just a small comment regarding the discard logic.

v2/robotmk/src/environment.rs Outdated Show resolved Hide resolved
v2/robotmk/src/environment.rs Outdated Show resolved Hide resolved
@jherbel jherbel self-requested a review October 24, 2023 05:40
jherbel
jherbel requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jherbel jherbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, chose "Approve" instead of "Request changes" before

@jherbel jherbel force-pushed the dev/sol/refactor_II branch from 4d126cd to 4e01afd Compare October 24, 2023 09:35
@jherbel jherbel self-requested a review October 24, 2023 09:36
@SoloJacobs
Don't return environment_build_states_administrator
197b98e 
This prepares removing drop suite.

CMK-14884
@SoloJacobs
Remove lifetime
d9a0599 
CMK-14884
@SoloJacobs
Remove drop_suites
36e72b6 
CMK-14884
@SoloJacobs SoloJacobs merged commit 31d5c89 into main Oct 24, 2023
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
@SoloJacobs SoloJacobs deleted the dev/sol/refactor_II branch October 26, 2023 07:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jherbel jherbel jherbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoloJacobs @jherbel