Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/sol/agent plugin #392

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Dev/sol/agent plugin #392

merged 6 commits into from
Oct 24, 2023

Conversation

SoloJacobs
Copy link
Contributor

No description provided.

@SoloJacobs SoloJacobs requested a review from jherbel October 23, 2023 15:37
jherbel
jherbel previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jherbel jherbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, I have some minor optional suggestions. Check if you agree with them. If not, it's also ok for me to merge it as is.

v2/robotmk/src/bin/agent.rs Outdated Show resolved Hide resolved
v2/robotmk/src/bin/agent.rs Show resolved Hide resolved
v2/robotmk/src/bin/agent.rs Outdated Show resolved Hide resolved
v2/robotmk/src/bin/agent.rs Show resolved Hide resolved
v2/robotmk/src/bin/agent.rs Show resolved Hide resolved
@jherbel jherbel force-pushed the dev/sol/agent_plugin branch from 16dce32 to d8545d1 Compare October 24, 2023 07:16
@jherbel jherbel self-requested a review October 24, 2023 07:16
jherbel
jherbel previously approved these changes Oct 24, 2023
View reviewed changes
SoloJacobs and others added 4 commits October 24, 2023 09:37
@SoloJacobs
Rewrite agent plugin in rust
e1184e5 
Also installs `walkdir`, for easy directory traversal.

CMK-14887
@SoloJacobs
Add test for walk
c47be62 
Also adds `tempfile` for easier testing.

CMK-14887
@SoloJacobs @jherbel
agent: small typing improvements and refactoring
a2bb3e7 
CMK-14887

Co-authored-by: Joerg Herbel <[email protected]>
@SoloJacobs
agent: use rust binary instead of powershell
ae811d2 
CMK-14887
@SoloJacobs SoloJacobs force-pushed the dev/sol/agent_plugin branch from d8545d1 to 58e4ceb Compare October 24, 2023 07:37
@SoloJacobs
Remove powershell
6830196 
Previously, the agent plugin and part of the extension were written in
powershell. Both have since be rewritten in Rust, making ci and the
scripts themselve redundant.

We have sofar "archived" most scripts. However, being able to easily
look up these scripts offers little benefit. Having them in the git
log should suffice. Thus, we delete them.

We also remove the corresponding ci jobs.

CMK-14887
@SoloJacobs
Cleanup shell provisioning script
890e8f3 
We don't use nushell. And our project no longer is python based.
@SoloJacobs SoloJacobs force-pushed the dev/sol/agent_plugin branch from 58e4ceb to 890e8f3 Compare October 24, 2023 08:01
@SoloJacobs SoloJacobs merged commit d9469c4 into main Oct 24, 2023
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
@SoloJacobs SoloJacobs deleted the dev/sol/agent_plugin branch October 26, 2023 07:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jherbel jherbel jherbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoloJacobs @jherbel