Limit number of text matches returned in search #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously (especially before using stop words), the search endpoint could return a vast number of text matches, slowing down network and frontend. This slow down needs to be avoided and, in those cases, seeing all the individual matches is not useful anyway. So we reduce the number of returned matches to a limit, without changing the "general look of the timeline" too much. See comments for more details.
The backend now returns them in sorted order already. And the frontend sorting mix slide-texts and captions, which lead to weird z-index issues.
This helps shrink GraphQL search responses a bit, makes queries less repetitive (no need to specify `start end` all the time), generally saves processing time (fewer JSON objects) and avoids having to use signed integers. In an example request, it shrank the response size from 210 to 190KB. Not a ton but still 10%.
owi92
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
This is working well and the code looks reasonable to me. I didn't see a noticable difference in performance, but I also didn't look at exact times, just going by feel.
At any rate, even without looking considering performance, I think it's quite useful to limit the results shown in the timeline (maybe a limit of 20 is even somewhat high, but I'd keep that for now).
I also couldn't find any terrible example of many hundreds of matches anymore after we merged the stop words thing. This PR is just a "backup" just to make sure these fringe cases never happen and slow down the frontend too much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last thing required for 3.0 as far as I can tell. See commits for more information.