Update ESLint and @opencast/eslint-config-ts-react
#1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update brought lots of new or stricter rules, leading to roughly 100 errors. Now is not the time to fix all of them, so I fixed the easier ones, disabling the remaining rules. Some boring changes and some good changes (mostly around conditional hooks).
This also finally updates this `ts-checker` thingy. In version 7 it removed eslint support, which blocked us from updating. But there is this other plugin for that now. And everything seems to work well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally updates ESLint to the new flat config format, including our shared config
@opencast/eslint-config-ts-react. This PR also updates another old dependency of Tobira. See commits for more information.A number of lints are disabled by this PR, as those were causing lint warnings. Note that this PR obviously doesn't make the code base worse, just because new stricter lints were added. I currently don't have the time to go through all lints failures. That can be done in the near future, one at a time. The important part is getting the update done.