build: bump org.springframework.boot:spring-boot-dependencies from 2.7.16 to 3.4.1 #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [org.springframework.boot:spring-boot-dependencies](https://github.com/spring-projects/spring-boot) from 2.7.16 to 3.4.1. - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v2.7.16...v3.4.1) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-dependencies dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
this appears to be a real regression break, presumably from spring changing something internal that we rely on |
SylvainJuge
reviewed
Jan 16, 2025
| @@ -133,7 +133,7 @@ private void hello(boolean expectHeaders) { | |||
|
|
|||
| assertThat(headersCount) | |||
| .describedAs("unexpected headers count") | |||
| .isEqualTo(6); | |||
| .isGreaterThanOrEqualTo(6); | |||
There was a problem hiding this comment.
[for reviewer] there is now 7 headers when only 6 were previously reported, here we don't really have a strict assertion on all of them, only a few are expected with specific values as seen in the assertions just below.
jackshirazi
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps org.springframework.boot:spring-boot-dependencies from 2.7.16 to 3.4.1.
Release notes
Sourced from org.springframework.boot:spring-boot-dependencies's releases.
... (truncated)
Commits
1832852Release v3.4.1c9e8174Merge branch '3.3.x'316fe52Next development version (v3.3.8-SNAPSHOT)4300ee9Merge branch '3.3.x'da59380Upgrade to Spring Batch 5.2.1a085a01Upgrade to Spring Batch 5.1.3fcc569eUpgrade to Hibernate 6.6.4.Final1b8fcb6Merge pull request #43560 from arefbehboudidbc1fc2Polishef43160Merge branch '3.3.x'Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)