Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete tomcat docker image from integration tests #3940

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

SylvainJuge
Copy link
Member

What does this PR do?

Removes the tomcat 8.5.0 docker image.

When trying to pull this docker image from CLI with docker pull tomcat:8.5.0-jre8 we get the following error:

8.5.0-jre8: Pulling from library/tomcat
[DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of docker.io/library/tomcat:8.5.0-jre8 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/

This docker image is being used by the co.elastic.apm.servlet.TomcatIT integration tests, which fails when run locally and in CI, but does not trigger a failure in CI, which will need proper investigation.

This 9 year old docker image is not maintained anymore, thus the simplest way to move forward is to remove it.

@SylvainJuge SylvainJuge requested a review from a team January 15, 2025 13:30
@JonasKunz
Copy link
Contributor

We'll wait on merging this one, because this PR removes our way to reproduce the CI issue where the CI is green even though some tests (=the tomcat test) failed.

@JonasKunz
Copy link
Contributor

Merging now, because the root cause of undetected CI failures has been found and will be fixed with #3952.

@JonasKunz JonasKunz merged commit 6cc2a84 into elastic:main Jan 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants