-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] [testing] update kafka version used in testing to 3.6.0 #41833
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
@elastic/obs-infraobs-integrations can someone from your team take a look. I've upgraded kafka to 3.6.0 and made corresponding changes according to docs. The broker seems to not be either listening on localhost 9091 or is inaccessible. The error logs are attached in description. cc: @lalit-satapathy |
@khushijain21 please have a look at the CI failures, it's Kafka related and looks relevant to the changes. |
@andresrc can we please have someone looking at this please? Wrt #41833 (comment) |
@Linu-Elias is taking a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the CI failures, they are mostly because the broker seems to not be listening on localhost:9091
@@ -80,17 +80,17 @@ func EnsureUp(t testing.TB, service string, options ...UpOption) HostInfo { | |||
} | |||
|
|||
// Wait for health | |||
err = compose.Wait(upOptions.Timeout, service) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest uncommenting this, and we can still wait for the health check to complete.
Co-authored-by: Linu-Elias <[email protected]>
Hi @khushijain21, Can you summarise what is exactly pending on this PR? Is there some structural issues in the existing tests that needs to be fixed or we have bigger compatibility issues in terms of package not compatible with the new kafka version, requiring further code changes? I will work to priorities this accordingly. |
Hello @lalit-satapathy, I think it is a structural issue as I have seen similar behaviour for version 2.9 as well. You may prioritize this accordingly, thanks! |
I think I've figured the solution for this change ( |
This has bee closed as @stefans-elastic is raising a new PR #42286 |
Closing this PR in favor of #42286 |
Proposed commit message
Updated kafka version used in our integration tests
Error logs
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Kafka version 4.0 will not be compatible with client libraries using protocol version less than 2.1.0
Related issues
Closes #41654