Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] [testing] update kafka version used in testing to 3.6.0 #41833

Closed
wants to merge 6 commits into from

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Nov 29, 2024

Proposed commit message

Updated kafka version used in our integration tests

Error logs

Error while executing ACL command: org.apache.kafka.common.errors.TimeoutException: Timed out waiting for a node assignment. Call: createAcls
java.util.concurrent.ExecutionException: org.apache.kafka.common.errors.TimeoutException: Timed out waiting for a node assignment. Call: createAcls
        at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
        at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)
        at org.apache.kafka.common.internals.KafkaFutureImpl.get(KafkaFutureImpl.java:165)
        at kafka.admin.AclCommand$AdminClientService.$anonfun$addAcls$3(AclCommand.scala:115)
        at scala.collection.TraversableLike$WithFilter.$anonfun$foreach$1(TraversableLike.scala:985)
        at scala.collection.immutable.Map$Map3.foreach(Map.scala:376)
        at scala.collection.TraversableLike$WithFilter.foreach(TraversableLike.scala:984)
        at kafka.admin.AclCommand$AdminClientService.$anonfun$addAcls$1(AclCommand.scala:112)
        at kafka.admin.AclCommand$AdminClientService.addAcls(AclCommand.scala:111)
        at kafka.admin.AclCommand$.main(AclCommand.scala:73)
        at kafka.admin.AclCommand.main(AclCommand.scala)
Caused by: org.apache.kafka.common.errors.TimeoutException: Timed out waiting for a node assignment. Call: createAcls

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Kafka version 4.0 will not be compatible with client libraries using protocol version less than 2.1.0

Related issues

Closes #41654

@khushijain21 khushijain21 requested review from a team as code owners November 29, 2024 10:26
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 29, 2024
@khushijain21 khushijain21 marked this pull request as draft November 29, 2024 10:26
@khushijain21 khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 29, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 29, 2024
Copy link
Contributor

mergify bot commented Nov 29, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 29, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 29, 2024
@khushijain21
Copy link
Contributor Author

khushijain21 commented Dec 5, 2024

@elastic/obs-infraobs-integrations can someone from your team take a look. I've upgraded kafka to 3.6.0 and made corresponding changes according to docs. The broker seems to not be either listening on localhost 9091 or is inaccessible. The error logs are attached in description.

cc: @lalit-satapathy

@rdner
Copy link
Member

rdner commented Dec 16, 2024

@khushijain21 please have a look at the CI failures, it's Kafka related and looks relevant to the changes.

@jlind23
Copy link
Collaborator

jlind23 commented Dec 17, 2024

@andresrc can we please have someone looking at this please? Wrt #41833 (comment)

@lalit-satapathy
Copy link
Contributor

@andresrc can we please have someone looking at this please? Wrt #41833 (comment)

@Linu-Elias is taking a look.

Copy link
Contributor

@Linu-Elias Linu-Elias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the CI failures, they are mostly because the broker seems to not be listening on localhost:9091

metricbeat/module/kafka/_meta/healthcheck.sh Outdated Show resolved Hide resolved
@@ -80,17 +80,17 @@ func EnsureUp(t testing.TB, service string, options ...UpOption) HostInfo {
}

// Wait for health
err = compose.Wait(upOptions.Timeout, service)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest uncommenting this, and we can still wait for the health check to complete.

@khushijain21 khushijain21 changed the title [draft] [testing] update kafka version used in testing [draft] [testing] update kafka version used in testing to 3.6.0 Dec 19, 2024
@lalit-satapathy
Copy link
Contributor

Hi @khushijain21,

Can you summarise what is exactly pending on this PR? Is there some structural issues in the existing tests that needs to be fixed or we have bigger compatibility issues in terms of package not compatible with the new kafka version, requiring further code changes?

I will work to priorities this accordingly.

@khushijain21
Copy link
Contributor Author

Hello @lalit-satapathy, I think it is a structural issue as I have seen similar behaviour for version 2.9 as well. You may prioritize this accordingly, thanks!

@stefans-elastic
Copy link
Contributor

I think I've figured the solution for this change (MODULE=kafka mage goIntegTest tests pass locally). For Illustration I've opened a PR with comments describing the additional changes that I've made - #42286.
One thing that I didn't mention in my PR - I had to uncomment that bock of code in libbeat/tests/compose/compose.go (it didn't work otherwise)

@lalit-satapathy
Copy link
Contributor

This has bee closed as @stefans-elastic is raising a new PR #42286

@stefans-elastic
Copy link
Contributor

Closing this PR in favor of #42286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicity test kafka 4.0 with new default protocol version 2.1.0
6 participants