Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental warning from journald input. #42107

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Remove experimental warning from journald input. #42107

merged 5 commits into from
Feb 3, 2025

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Dec 18, 2024

Mark the journald input as GA now that it is used as part of the system module and Elastic Agent system integration to collect system logs on Linux distributions that do not enable syslog by default.

@cmacknz cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 18, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 18, 2024
@cmacknz cmacknz requested a review from flexitrev December 18, 2024 15:23
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 18, 2024
@cmacknz cmacknz requested a review from belimawr December 18, 2024 15:23
@cmacknz cmacknz self-assigned this Dec 18, 2024
@cmacknz cmacknz added backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify labels Dec 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @cmacknz? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

belimawr
belimawr reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to update the "stability" of the input:

beats/filebeat/input/journald/input.go

Line 76 in 3cdd856

Stability: feature.Experimental,

That forces some deprecation logs. I believe that's the only place.

@cmacknz cmacknz requested a review from a team as a code owner December 18, 2024 15:35
@cmacknz cmacknz requested a review from mauri870 December 18, 2024 15:35
@cmacknz
Copy link
Member Author

cmacknz commented Dec 18, 2024

Thanks for catching that, updated.

@cmacknz cmacknz removed the backport-8.17 Automated backport with mergify label Dec 18, 2024
@cmacknz
Copy link
Member Author

cmacknz commented Dec 18, 2024

Removing backport to 8.17 until elastic/integrations#9690 is addressed.

flexitrev
flexitrev approved these changes Dec 19, 2024
View reviewed changes
Copy link

@flexitrev flexitrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cmacknz cmacknz added the backport-8.18 Automated backport to the 8.18 branch label Jan 31, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 31, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mark-journald-ga upstream/mark-journald-ga
git merge upstream/main
git push upstream mark-journald-ga

@cmacknz cmacknz enabled auto-merge (squash) February 3, 2025 21:15
@cmacknz cmacknz merged commit b4046f9 into elastic:main Feb 3, 2025
31 checks passed
mergify bot pushed a commit that referenced this pull request Feb 3, 2025
@cmacknz @mergify
Remove experimental warning from journald input. (#42107)
0b9a729 
* Remove experimental warning from journald input.

* Add changelog.

* Mark journald input as Stable.

(cherry picked from commit b4046f9)
@mergify mergify bot mentioned this pull request Feb 3, 2025
Merged
mergify bot pushed a commit that referenced this pull request Feb 3, 2025
@cmacknz @mergify
Remove experimental warning from journald input. (#42107)
085f113 
* Remove experimental warning from journald input.

* Add changelog.

* Mark journald input as Stable.

(cherry picked from commit b4046f9)
@mergify mergify bot mentioned this pull request Feb 3, 2025
Merged
@cmacknz cmacknz added the backport-9.0 Automated backport to the 9.0 branch label Feb 4, 2025
@cmacknz cmacknz deleted the mark-journald-ga branch February 4, 2025 14:55
mergify bot pushed a commit that referenced this pull request Feb 4, 2025
@cmacknz @mergify
Remove experimental warning from journald input. (#42107)
5dee05a 
* Remove experimental warning from journald input.

* Add changelog.

* Mark journald input as Stable.

(cherry picked from commit b4046f9)
@mergify mergify bot mentioned this pull request Feb 4, 2025
Merged
rdner added a commit that referenced this pull request Feb 4, 2025
@mergify @cmacknz @rdner
Remove experimental warning from journald input. (#42107) (#42592)
c60042a 
* Remove experimental warning from journald input.

* Add changelog.

* Mark journald input as Stable.

(cherry picked from commit b4046f9)

Co-authored-by: Craig MacKenzie <[email protected]>
Co-authored-by: Denis <[email protected]>
cmacknz added a commit that referenced this pull request Feb 4, 2025
@mergify @cmacknz
[8.x](backport #42107) Remove experimental warning from journald inpu…
3591e83 
…t. (#42580)

* Remove experimental warning from journald input. (#42107)

* Remove experimental warning from journald input.

* Add changelog.

* Mark journald input as Stable.

(cherry picked from commit b4046f9)

* Fix conflict in CHANGELOG.next.asciidoc

---------

Co-authored-by: Craig MacKenzie <[email protected]>
cmacknz added a commit that referenced this pull request Feb 4, 2025
@mergify @cmacknz
[8.18](backport #42107) Remove experimental warning from journald inp…
92ff3bd 
…ut. (#42581)

* Remove experimental warning from journald input. (#42107)

* Remove experimental warning from journald input.

* Add changelog.

* Mark journald input as Stable.

(cherry picked from commit b4046f9)

* Fix conflict in CHANGELOG.next.asciidoc

---------

Co-authored-by: Craig MacKenzie <[email protected]>
cmacknz added a commit that referenced this pull request Feb 4, 2025
@cmacknz
Revert "[8.18](backport #42107) Remove experimental warning from jour…
5b4fd7a 
…nald inp…"

This reverts commit 92ff3bd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr belimawr approved these changes

@mauri870 mauri870 mauri870 approved these changes

@flexitrev flexitrev flexitrev approved these changes

Assignees

@cmacknz cmacknz

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cmacknz @elasticmachine @belimawr @mauri870 @flexitrev