Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Prepare Changelog for 8.16.3 #42301

Merged
merged 2 commits into from
Jan 20, 2025
Merged

docs: Prepare Changelog for 8.16.3 #42301

merged 2 commits into from
Jan 20, 2025

Conversation

elastic-vault-github-plugin-prod[bot]
Copy link
Contributor

Prepare Changelog for 8.16.3.

Merge once the BC that will be published is decided.

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner January 13, 2025 16:13
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot added docs in progress Pull request is currently in progress. release automation Team:Automation Label for the Observability productivity team labels Jan 13, 2025
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested review from faec and leehinman and removed request for a team January 13, 2025 16:13
@michalpristas michalpristas deleted the prepare-changelog-8.16.3 branch January 20, 2025 09:42
@michalpristas michalpristas restored the prepare-changelog-8.16.3 branch January 20, 2025 09:43
@michalpristas michalpristas reopened this Jan 20, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 20, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b prepare-changelog-8.16.3 upstream/prepare-changelog-8.16.3
git merge upstream/8.16
git push upstream prepare-changelog-8.16.3

@michalpristas michalpristas merged commit e3b56a2 into 8.16 Jan 20, 2025
141 checks passed
@michalpristas michalpristas deleted the prepare-changelog-8.16.3 branch January 20, 2025 16:15
cmacknz
cmacknz reviewed Jan 20, 2025
View reviewed changes
CHANGELOG.asciidoc

*Affecting all Beats*

- Fix FQDN being lowercased when used as `host.hostname` {issue}39993[39993]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and maybe other) entries were already released. See

beats/CHANGELOG.asciidoc

Line 451 in e3b56a2

- Fix FQDN being lowercased when used as `host.hostname`. {issue}39993[39993]

I suspect the whatever base the changelog process is using to move the entries around is not up to date, either that or merge conflicts did this.

@kilfoyle kilfoyle added backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify labels Jan 21, 2025
mergify bot pushed a commit that referenced this pull request Jan 21, 2025
@elastic-vault-github-plugin-prod @mergify
docs: Close changelog for 8.16.3 (#42301)
e7bd6f0 
Co-authored-by: elasticmachine <[email protected]>
Co-authored-by: Michal Pristas <[email protected]>
(cherry picked from commit e3b56a2)

# Conflicts:
#	CHANGELOG.asciidoc
#	libbeat/docs/release.asciidoc
mergify bot pushed a commit that referenced this pull request Jan 21, 2025
@elastic-vault-github-plugin-prod @mergify
docs: Close changelog for 8.16.3 (#42301)
b0b37b5 
Co-authored-by: elasticmachine <[email protected]>
Co-authored-by: Michal Pristas <[email protected]>
(cherry picked from commit e3b56a2)

# Conflicts:
#	CHANGELOG.asciidoc
#	libbeat/docs/release.asciidoc
This was referenced Jan 21, 2025
Closed
Closed
@kilfoyle
Copy link
Contributor

kilfoyle commented Jan 21, 2025 •
edited
Loading

The 8.16.2 and 8.16.3 Release Notes aren't showing up in the 8.17 (current) docs build, I think because this PR needs to be backported into 8.x and 8.17, so I've added those backports.

Screenshot 2025-01-21 at 9 21 03 AM

@kilfoyle
Copy link
Contributor

Ugh. Sorry @michalpristas! I didn't realize that Craig's comment up above should be addressed before backporting, so I've closed my backport PRs. I am backporting the the 8.16.2 changelog PR into 8.x (#42364) and 8.17 (#42365) now, since that was missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz left review comments

@jlind23 jlind23 jlind23 approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@elasticmachine elasticmachine

Labels
automation backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify docs in progress Pull request is currently in progress. release Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kilfoyle @cmacknz @jlind23 @michalpristas @elasticmachine