Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the system-logs input #42328

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Conversation

belimawr
Copy link
Contributor

Proposed commit message

The system-logs input was created to support reading syslog and auth logs from Linux hosts by the system module, but at the end it was decided not to use it.

This commit removes its code and references.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None

## Author's Checklist
## How to test this PR locally
## Related issues
## Use cases
## Screenshots
## Logs

@belimawr belimawr added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-8.x Automated backport to the 8.x branch with mergify labels Jan 16, 2025
@belimawr belimawr self-assigned this Jan 16, 2025
@belimawr belimawr requested a review from a team as a code owner January 16, 2025 18:07
@belimawr belimawr requested review from rdner and leehinman January 16, 2025 18:07
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 16, 2025
The system-logs input was created to support reading syslog and auth
logs from Linux hosts by the system module, but at the end it was
decided not to use it.

This commit removes its code and references.
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any documentation we need to remove or it never made to a release and was not documented?

CHANGELOG-developer.next.asciidoc Outdated Show resolved Hide resolved
@belimawr
Copy link
Contributor Author

any documentation we need to remove or it never made to a release and was not documented?

It made into a release, but there was no documentation, it was meant for internal use only, it was supposed to be used by the system module.

@belimawr belimawr merged commit fd9570d into elastic:main Jan 21, 2025
31 checks passed
mergify bot pushed a commit that referenced this pull request Jan 21, 2025
The system-logs input was created to support reading syslog and auth
logs from Linux hosts by the system module, but at the end it was
decided not to use it.

This commit removes its code and references.
---------

Co-authored-by: Denis <[email protected]>
(cherry picked from commit fd9570d)
belimawr added a commit that referenced this pull request Jan 24, 2025
The system-logs input was created to support reading syslog and auth
logs from Linux hosts by the system module, but at the end it was
decided not to use it.

This commit removes its code and references.
---------

Co-authored-by: Denis <[email protected]>
(cherry picked from commit fd9570d)

Co-authored-by: Tiago Queiroz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants