Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent 'thundering herd' issue with the scale preset #42329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

faec
Copy link
Contributor

@faec faec commented Jan 16, 2025

Add backoff settings to the scale performance preset, as described in elastic/elastic-agent#4469, to reduce load on large deployments.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

If users have already set an output backoff while using the scale preset, this will override it (and possibly reduce the effective backoff).

However, this reduces cluster overload in the more common case that users have default backoff settings.

Related issues

@faec faec added the bug label Jan 16, 2025
@faec faec self-assigned this Jan 16, 2025
@faec faec requested a review from a team as a code owner January 16, 2025 23:15
@faec faec requested review from belimawr and rdner January 16, 2025 23:15
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @faec? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 16, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 16, 2025
@faec faec added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed backport-8.x Automated backport to the 8.x branch with mergify labels Jan 16, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 16, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale Preset should prevent Thundering Herd issue with many Agents
3 participants