-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Journald] update include_matches
#42517
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise looks good.
This commit extends the `include_matches` syntax to accept a disjunction (i.e. logical OR) represented by `+`. Some unused code has been removed, the documentation and examples are updated. (cherry picked from commit 090584e)
This commit extends the `include_matches` syntax to accept a disjunction (i.e. logical OR) represented by `+`. Some unused code has been removed, the documentation and examples are updated. (cherry picked from commit 090584e)
Proposed commit message
This commit extends the
include_matches
syntax to accept adisjunction (i.e. logical OR) represented by
+
. Some unused code hasbeen removed, the documentation and examples are updated.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.## Disruptive User Impact## Author's ChecklistHow to test this PR locally
Related issues
include_matches
to reach feature parity with what is exposed byjournalctl
#40185## Use cases## Screenshots## Logs