-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fips): return an error when creating a kerberos client #42597
Conversation
kerberos lib is implementing a lot of crypto :(
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me as part of #42867. However, in addition to returning an error when creating the Kerberos client, the beats should not expose and support any Kerberos related configuration in the first place.
@kruskall are you planning on tackling this as follow up work? (please see the sub issues in #42867).
I'll open a PR for the configuration separately |
* feat(fips): return an error when creating a kerberos client kerberos lib is implementing a lot of crypto :( * test: add kerberos client tests --------- Co-authored-by: Pierre HILBERT <[email protected]> (cherry picked from commit bbfa290)
* feat(fips): return an error when creating a kerberos client kerberos lib is implementing a lot of crypto :( * test: add kerberos client tests --------- Co-authored-by: Pierre HILBERT <[email protected]> (cherry picked from commit bbfa290)
* feat(fips): return an error when creating a kerberos client kerberos lib is implementing a lot of crypto :( * test: add kerberos client tests --------- Co-authored-by: Pierre HILBERT <[email protected]> (cherry picked from commit bbfa290)
Proposed commit message
return an error when creating a kerberos client in fips mode
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
related to #42867
Use cases
Screenshots
Logs