Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fips): return an error when creating a kerberos client #42597

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Feb 5, 2025

Proposed commit message

return an error when creating a kerberos client in fips mode

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

related to #42867

Use cases

Screenshots

Logs

kerberos lib is implementing a lot of crypto :(
@kruskall kruskall requested a review from a team as a code owner February 5, 2025 01:43
@kruskall kruskall requested review from belimawr and mauri870 February 5, 2025 01:43
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 5, 2025
Copy link
Contributor

mergify bot commented Feb 5, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Feb 5, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 5, 2025
@kruskall kruskall requested review from mauri870 and simitt February 24, 2025 15:28
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me as part of #42867. However, in addition to returning an error when creating the Kerberos client, the beats should not expose and support any Kerberos related configuration in the first place.

@kruskall are you planning on tackling this as follow up work? (please see the sub issues in #42867).

@kruskall kruskall added backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch labels Feb 25, 2025
@kruskall kruskall merged commit bbfa290 into elastic:main Feb 25, 2025
143 checks passed
@kruskall kruskall deleted the feat/fips-kerberos branch February 25, 2025 11:51
@kruskall
Copy link
Member Author

I'll open a PR for the configuration separately

mergify bot pushed a commit that referenced this pull request Feb 25, 2025
* feat(fips): return an error when creating a kerberos client

kerberos lib is implementing a lot of crypto :(

* test: add kerberos client tests

---------

Co-authored-by: Pierre HILBERT <[email protected]>
(cherry picked from commit bbfa290)
mergify bot pushed a commit that referenced this pull request Feb 25, 2025
* feat(fips): return an error when creating a kerberos client

kerberos lib is implementing a lot of crypto :(

* test: add kerberos client tests

---------

Co-authored-by: Pierre HILBERT <[email protected]>
(cherry picked from commit bbfa290)
mergify bot pushed a commit that referenced this pull request Feb 25, 2025
* feat(fips): return an error when creating a kerberos client

kerberos lib is implementing a lot of crypto :(

* test: add kerberos client tests

---------

Co-authored-by: Pierre HILBERT <[email protected]>
(cherry picked from commit bbfa290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants