Minor CI lint/notice steps improvement (#3089)

Co-authored-by: Elastic Machine <[email protected]>

.buildkite/run_linter.sh

@@ -19,6 +19,7 @@ if is_pr; then
     echo "Nothing to be fixed by autoformat"
     exit 0
   else
+    git --no-pager diff
     echo "linting errors are fixed, pushing the diff"
     export GH_TOKEN="$VAULT_GITHUB_TOKEN"
 

.buildkite/run_notice_check.sh

@@ -13,6 +13,7 @@ make notice
 if [ -z "$(git status --porcelain | grep NOTICE.txt)" ]; then
   exit 0
 else 
+  git --no-pager diff
   if is_pr; then
     export GH_TOKEN="$VAULT_GITHUB_TOKEN"
 

.buildkite/shared.sh

@@ -28,27 +28,9 @@ retry() {
 }
 
 is_pr() {
-  [[ "${BUILDKITE_PULL_REQUEST-}" ]] && return
-  false
-}
-
-retry() {
-  local retries=$1; shift
-  local delay=$1; shift
-  local attempts=1
-
-  until "$@"; do
-    retry_exit_status=$?
-    echo "Exited with $retry_exit_status" >&2
-    if (( retries == "0" )); then
-      return $retry_exit_status
-    elif (( attempts == retries )); then
-      echo "Failed $attempts retries" >&2
-      return $retry_exit_status
-    else
-      echo "Retrying $((retries - attempts)) more times..." >&2
-      attempts=$((attempts + 1))
-      sleep "$delay"
-    fi
-  done
+  if [ -z "$BUILDKITE_PULL_REQUEST" ] || [ "$BUILDKITE_PULL_REQUEST" = "false"]; then
+    return 1 # false
+  else
+    return 0 # true
+  fi
 }