-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt mongo ndjson serialize fix #1615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangch079
approved these changes
Sep 22, 2023
Good stuff, @seanstory wanna test and merge? |
@seanstory do you wanna merge this? |
Yeah let's go ahead. I haven't heard back from the community member who reported, but even if this doesn't fix the root issue, it's an improvement. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Artem Shelkovnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1605
Attempts to handle
DBRef
bson types, to avoid NDJSON serialization errors from the elasticsearch-python client.Also adds stacktrace logging for when callback coroutines log errors.
Checklists
Pre-Review Checklist
v7.13.2
,v7.14.0
,v8.0.0
)Release Note
Fixes a bug where Mongodb records containing BSON
DBRef
fields could not be indexed to Elasticsearch and caused sync failures.