Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt mongo ndjson serialize fix #1615

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

seanstory
Copy link
Member

closes #1605

Attempts to handle DBRef bson types, to avoid NDJSON serialization errors from the elasticsearch-python client.
Also adds stacktrace logging for when callback coroutines log errors.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes

Release Note

Fixes a bug where Mongodb records containing BSON DBRef fields could not be indexed to Elasticsearch and caused sync failures.

@artem-shelkovnikov
Copy link
Member

Good stuff, @seanstory wanna test and merge?

@artem-shelkovnikov
Copy link
Member

@seanstory do you wanna merge this?

@seanstory seanstory enabled auto-merge (squash) November 27, 2023 18:50
@seanstory
Copy link
Member Author

Yeah let's go ahead. I haven't heard back from the community member who reported, but even if this doesn't fix the root issue, it's an improvement.

@seanstory seanstory merged commit 80e83ae into main Nov 27, 2023
@seanstory seanstory deleted the seanstory/attempt-mongo-ndjson-serialize-fix branch November 27, 2023 19:01
github-actions bot pushed a commit that referenced this pull request Nov 27, 2023
Copy link

💚 Backport PR(s) successfully created

Status Branch Result
8.11 #1927

This backport PR will be merged automatically after passing CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The connector fails to sync data from mongo with the following exception
3 participants