Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network Drive] Add Dropdown for Drive type #1842

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

praveen-kukreja
Copy link
Contributor

Closes #1841

This PR addresses following issue:

  • Added a configurable field for Drive type as discussed in weekly sync with @danajuratoni. This field will be visible when the DLS is enabled and it allows two values Linux and Windows as the connector supports DLS for Linux and Windows Network Drives only. Further it is kept advanced field as the native connector flows only supports DLS in Windows Network Drive. The support for Linux Network Drive is added via csv path that can only be used via self-managed connector client flow (Add support for DLS in Linux Network Drive #1773 )

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference

@praveen-kukreja praveen-kukreja changed the title [Network Drive] Add missing try except and dropdown for Drive type [Network Drive] Add Dropdown for Drive type Oct 26, 2023
@praveen-kukreja praveen-kukreja requested a review from vidok October 26, 2023 08:51
@parth-elastic parth-elastic merged commit c3a230e into main Oct 30, 2023
@parth-elastic parth-elastic deleted the praveen/bugfix-dls-network-drive branch October 30, 2023 06:22
@github-actions
Copy link

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 1842 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Network Drive] Add new configurable field for Drive type when DLS enabled
3 participants