Make pending_jobs fetch jobs by job types #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangch079
changed the base branch from
main
to
chenhui/job-execution-service-concurrency
6 tasks
wangch079
changed the title
|
Do you think this can be merged to |
Since it won't change output of pending_jobs func I think it can be safely merged to main |
wangch079
changed the base branch from
chenhui/job-execution-service-concurrency
to
main
wangch079
force-pushed
the
chenhui/fetch-pending-jobs-by-job-types
branch
from
e5d50e8 to
9acfde3
Compare
jedrazb
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/elastic/enterprise-search-team/issues/5193
Make the
pending_jobsmethod ofSyncJobIndexto be able to fetch pending jobs by job type. This is to prepare for the PR Break JobExecutionSerivce to ContentSyncJobExecutionService and AccessControlSyncJobExecutionService.Checklists
Pre-Review Checklist
v7.13.2,v7.14.0,v8.0.0)