Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some instance variables to BaseService #1851

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Move some instance variables to BaseService #1851

merged 2 commits into from
Oct 30, 2023

Conversation

wangch079
Copy link
Member

Move some common instance variables to BasecService class.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

@wangch079 wangch079 requested a review from a team October 27, 2023 16:49
jedrazb
jedrazb approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@jedrazb jedrazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wangch079 wangch079 merged commit aab01d3 into main Oct 30, 2023
@wangch079 wangch079 deleted the chenhui/move-instance-variables-to-base branch October 30, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedrazb jedrazb jedrazb approved these changes

Assignees
No one assigned
Labels
v8.12.0 v8.12.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangch079 @jedrazb