Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage for connectors.utils module #1864

Merged
merged 7 commits into from
Nov 6, 2023

Conversation

artem-shelkovnikov
Copy link
Member

We're super close to 92% test coverage and minor refactors that I started in #1857 and #1863 started to fail due to low code coverage.

This PR improves code coverage for connectors.utils module to make space for refactorings to continue.

seanstory
seanstory previously approved these changes Nov 2, 2023
tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
@artem-shelkovnikov artem-shelkovnikov force-pushed the artem/increase-utils-test-coverage branch from 488f4bc to 23c1fc1 Compare November 3, 2023 13:01
@artem-shelkovnikov artem-shelkovnikov requested a review from a team November 3, 2023 13:23
@artem-shelkovnikov artem-shelkovnikov enabled auto-merge (squash) November 3, 2023 14:03
tests/test_utils.py Outdated Show resolved Hide resolved
@artem-shelkovnikov artem-shelkovnikov changed the title Increase test coverage for connectors.utils module Increase test coverage for connectors.utils and connectors.cli modules Nov 6, 2023
@artem-shelkovnikov artem-shelkovnikov changed the title Increase test coverage for connectors.utils and connectors.cli modules Increase test coverage for connectors.utils module Nov 6, 2023
@artem-shelkovnikov artem-shelkovnikov merged commit 3296f6c into main Nov 6, 2023
@artem-shelkovnikov artem-shelkovnikov deleted the artem/increase-utils-test-coverage branch November 6, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants