-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase test coverage for connectors.utils module #1864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanstory
previously approved these changes
Nov 2, 2023
wangch079
reviewed
Nov 3, 2023
artem-shelkovnikov
force-pushed
the
artem/increase-utils-test-coverage
branch
from
November 3, 2023 13:01
488f4bc
to
23c1fc1
Compare
vidok
reviewed
Nov 6, 2023
artem-shelkovnikov
changed the title
Increase test coverage for connectors.utils module
Increase test coverage for connectors.utils and connectors.cli modules
Nov 6, 2023
artem-shelkovnikov
changed the title
Increase test coverage for connectors.utils and connectors.cli modules
Increase test coverage for connectors.utils module
Nov 6, 2023
vidok
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're super close to 92% test coverage and minor refactors that I started in #1857 and #1863 started to fail due to low code coverage.
This PR improves code coverage for
connectors.utils
module to make space for refactorings to continue.