Add get and update meta methods to ESIndex #1896
Conversation
wangch079
force-pushed
the
chenhui/telemetry-last-sent
branch
from
ae7e76e to
86346e5
Compare
| async def meta(self): | ||
| response = await self.client.indices.get_mapping(index=self.index_name) | ||
| # Assume index name is the same pattern and the latest index is always the one with the largest suffix | ||
| latest_index = max(response.keys()) | ||
| return response[latest_index].get("mappings", {}).get("_meta") |
There was a problem hiding this comment.
I vaguely remember, that calls to get_mappings are very expensive on loaded clusters.
How often do we intend to do the calls?
There was a problem hiding this comment.
About every one hour (by the default interval)
I vaguely remember, that calls to
get_mappingsare very expensive on loaded clusters.
This is new to me, 🤔 get_mappings will only try to get the mappings of the index, not the docs.
There was a problem hiding this comment.
get_mappingswill only try to get the mappings of the index, not the docs.
True, but afaik it's one of operations that are "stop the world" and block other operations running on this index (or cluster?).
I just highlight it as something to double check with Elasticsearch team
|
Close the PR as we will move telemetry data collection to Kibana |
Part of https://github.com/elastic/enterprise-search-team/issues/6169
This PR adds a method
meta(getmetaof an index) andupdate_meta(updatemetaof an index) toESIndex.The two new methods will be used in the subsequent PRs, where
telemetry_last_sentwill be stored in themetaof.elastic-connectors.Checklists
Pre-Review Checklist
v7.13.2,v7.14.0,v8.0.0)