Skip empty permission batches #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangch079
reviewed
Nov 29, 2023
|
@seanstory I'm adding this to release notes, let me know if anything changes |
wangch079
approved these changes
Nov 29, 2023
seanstory
added a commit
that referenced
this pull request
Nov 29, 2023
Co-authored-by: Sean Story <[email protected]>
seanstory
added a commit
that referenced
this pull request
Nov 29, 2023
Co-authored-by: Sean Story <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1930
Skips running a
postrequest to the$batchendpoint if the requests list is empty.I can't actually see how we could get in this situation, but the linked ticket shows that we are getting into this spot. I'd rather track down the root cause, but figured a patch for the symptom was better than not solving anything.
Checklists
Pre-Review Checklist
v7.13.2,v7.14.0,v8.0.0)Release Note
Fixes a bug where the Sharepoint Online connector might sometimes fail syncs when DLS was enabled due to a batching error.