Followup on #2861 #2923
Merged
Followup on #2861 #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
31
to
33
| logger.debug( | ||
| "Agent configuration is not ready to create a connector record." | ||
| ) |
There was a problem hiding this comment.
Can we update the copy to provide more specific detail on what's going on? How can configuration be not ready? Is it gonna be happening a lot?
There was a problem hiding this comment.
Is it gonna be happening a lot?
It should not be happening at all... just here to verify that the config is 100% what we expect this to be. We only call ensure_connector_records_exist once we have ES output from the agent protocol checkin.
…-python into jedrazb-2861-followup
artem-shelkovnikov
previously approved these changes
Nov 5, 2024
Co-authored-by: Artem Shelkovnikov <[email protected]>
artem-shelkovnikov
approved these changes
Nov 7, 2024
💔 Failed to create backport PR(s)The backport operation could not be completed due to the following error: The backport PRs will be merged automatically after passing CI. To backport manually run: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on unaddressed comments from #2861
Addressed items:
connector_existsto ConnectorIndex classgenerate_random_idto utils class