-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Google Drive - Presentation to Markdown / Audio|Video Transcribed (10MB Limit) #3075
Conversation
…#2692) Co-authored-by: Sean Story <[email protected]>
…e id and adding support for views (elastic#2681) (elastic#2688) Co-authored-by: parthpuri-elastic <[email protected]>
…tic#2699) (elastic#2700) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
elastic#2713) Co-authored-by: Liam Thompson <[email protected]>
…elastic#2715) Co-authored-by: Artem Shelkovnikov <[email protected]>
…tic#2721) (elastic#2724) Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com> Co-authored-by: Giannicola Olivadoti <[email protected]> Co-authored-by: Artem Shelkovnikov <[email protected]>
Co-authored-by: Artem Shelkovnikov <[email protected]>
…lastic#2737) Co-authored-by: parthpuri-elastic <[email protected]>
Co-authored-by: Sean Story <[email protected]>
) Co-authored-by: Artem Shelkovnikov <[email protected]>
…tic#2856) Co-authored-by: Sean Story <[email protected]>
elastic#2871) Co-authored-by: Sean Story <[email protected]>
…elastic#2881) (elastic#2900) Co-authored-by: Artem Shelkovnikov <[email protected]>
…) (elastic#2973) Co-authored-by: Sean Story <[email protected]> Co-authored-by: Artem Shelkovnikov <[email protected]>
…nner (elastic#2984) (elastic#2988) Co-authored-by: Jedr Blaszyk <[email protected]>
Added the ability to send presentations to azure openai gpt-4o-mini for conversation to markdown Added the ability for audio/video files under 25MB to be sent to azure open whisper model for output to text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you may need to rebase and force-push - you're pulling in a lot of diff that is not yours.
Also, it looks like you're tightly coupling the Google Drive connector to an Azure AI tool. Which doesn't make a lot of sense to me.
I don't see this being mergable. If you'd like to have a chat with the team in #connectors-feedback, we can discuss how we can work to better integrate with LLM tools, but this diff as I understand it does not align with our vision for the architecture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to Sean's points.
If we want similar functionallity, specific connectors are not the place to do it. Should be either supported framework-wise, or on later stages such as ingest pipelines.
Thanks for the review, and I agree with all points. I am glad to see that this is kicking a more considerable discussion because markdown and text are the future for any GenAI use cases. 😄 |
Closes #3073 & #3074
In the Google Drive source this adds the functionality to convert Presentation to Markdown using Azure's OpenAI models and using Whisper service to transcribe audio or video to text with the limit of 10MB.
Checklists
Pre-Review Checklist
config.yml.example
)v7.13.2
,v7.14.0
,v8.0.0
)Changes Requiring Extra Attention
This adds external services for Azure hosted OpenAI GPT4-mini and Whisper API's
Related Pull Requests
Release Note