DRA release pipeline, pass qualifier to release cli #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-shelkovnikov
previously approved these changes
Jan 13, 2025
artem-shelkovnikov
approved these changes
Jan 13, 2025
seanstory
added a commit
that referenced
this pull request
Jan 13, 2025
This reverts commit c1ef211.
artem-shelkovnikov
pushed a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/search-team/issues/9111
It seems like we need to pass
--qualifierto the release pipeline. Reading the cli implementation, I understand this is an optional arg (source) so skipping checks for undefined.If I understand correctly, we only ever populate this via manual trigger of release pipeline.