[Rule Tuning] User Added to Privileged Group #3763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rk3r
added
Rule: Tuning
w0rk3r
requested review from
brokensound77,
DefSecSentinel,
Samirbous,
Aegrah and
terrancedejesus
w0rk3r
changed the title
Samirbous
approved these changes
Jun 7, 2024
Comment on lines
90
to
99
| group.id : ( | ||
| "S-1-5-32-544", | ||
| "S-1-5-32-544", | ||
| "S-1-5-21-*-512", | ||
| "S-1-5-21-*-519", | ||
| "S-1-5-21-*-551", | ||
| "S-1-5-21-*-518", | ||
| "S-1-5-21-*-1101", | ||
| "S-1-5-21-*-1102" | ||
| ) |
There was a problem hiding this comment.
better use endswith for performance when using multi wildcards checks, also not sure if 1101 and 1102 are std group ids ?
Suggested change
| group.id : ( | |
| "S-1-5-32-544", | |
| "S-1-5-32-544", | |
| "S-1-5-21-*-512", | |
| "S-1-5-21-*-519", | |
| "S-1-5-21-*-551", | |
| "S-1-5-21-*-518", | |
| "S-1-5-21-*-1101", | |
| "S-1-5-21-*-1102" | |
| ) | |
| endswith(group.id, "S-1-5-32-544", "-512", "-519", "-551", "-518") | |
| ) |
There was a problem hiding this comment.
1101 and 1102
Not sure either, but these are commonly related to the DNS Admins group, but it seems that there is no "official" RID for it
There was a problem hiding this comment.
better use endswith for performance when using multi wildcards checks
Isn't that the same as using the wildcard? I think this was the conclusion
rules/windows/persistence_user_account_added_to_privileged_group_ad.toml
Outdated
Show resolved
Hide resolved
rules/windows/persistence_user_account_added_to_privileged_group_ad.toml
Show resolved
Hide resolved
terrancedejesus
approved these changes
Jun 7, 2024
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 7, 2024
* [New Rule] User Added to Privileged Group * add more groups * Update rules/windows/persistence_user_account_added_to_privileged_group_ad.toml Co-authored-by: Terrance DeJesus <[email protected]> * Update persistence_user_account_added_to_privileged_group_ad.toml --------- Co-authored-by: Terrance DeJesus <[email protected]> (cherry picked from commit 087e8a6)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 7, 2024
* [New Rule] User Added to Privileged Group * add more groups * Update rules/windows/persistence_user_account_added_to_privileged_group_ad.toml Co-authored-by: Terrance DeJesus <[email protected]> * Update persistence_user_account_added_to_privileged_group_ad.toml --------- Co-authored-by: Terrance DeJesus <[email protected]> (cherry picked from commit 087e8a6)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 7, 2024
* [New Rule] User Added to Privileged Group * add more groups * Update rules/windows/persistence_user_account_added_to_privileged_group_ad.toml Co-authored-by: Terrance DeJesus <[email protected]> * Update persistence_user_account_added_to_privileged_group_ad.toml --------- Co-authored-by: Terrance DeJesus <[email protected]> (cherry picked from commit 087e8a6)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 7, 2024
* [New Rule] User Added to Privileged Group * add more groups * Update rules/windows/persistence_user_account_added_to_privileged_group_ad.toml Co-authored-by: Terrance DeJesus <[email protected]> * Update persistence_user_account_added_to_privileged_group_ad.toml --------- Co-authored-by: Terrance DeJesus <[email protected]> (cherry picked from commit 087e8a6)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 7, 2024
* [New Rule] User Added to Privileged Group * add more groups * Update rules/windows/persistence_user_account_added_to_privileged_group_ad.toml Co-authored-by: Terrance DeJesus <[email protected]> * Update persistence_user_account_added_to_privileged_group_ad.toml --------- Co-authored-by: Terrance DeJesus <[email protected]> (cherry picked from commit 087e8a6)
protectionsmachine
pushed a commit
that referenced
this pull request
Jun 7, 2024
* [New Rule] User Added to Privileged Group * add more groups * Update rules/windows/persistence_user_account_added_to_privileged_group_ad.toml Co-authored-by: Terrance DeJesus <[email protected]> * Update persistence_user_account_added_to_privileged_group_ad.toml --------- Co-authored-by: Terrance DeJesus <[email protected]> (cherry picked from commit 087e8a6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Related to #3005
Summary
Expands the rule to detect modifications to these groups on non-English AD envs.