Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rule Tuning] 3rd Party EDR Compatibility - 4 #4021

Merged
merged 6 commits into from
Oct 11, 2024
Merged

[Rule Tuning] 3rd Party EDR Compatibility - 4 #4021

merged 6 commits into from
Oct 11, 2024

Conversation

w0rk3r
Copy link
Contributor

@w0rk3r w0rk3r commented Aug 27, 2024 •
edited
Loading

Issues

Summary

Adjusts to rules to introduce or improve compatibility and documentation with 3rd party data such as Sysmon, MDE, and S1.

EDR field compatibility matrix: https://docs.google.com/spreadsheets/d/1ZaRmSXIVYLO9AGXeZge3u0W938aGxbfd6Vha52Rs1_I/edit?usp=sharing

Blocker

To use SentinelOne cloud funnel data right now, we would need to min_stack the rules to 8.13, so we are going to hold off on merging these until 8.16 is released and support for 8.12 is dropped. The updated_date is set to the 8.16 public release date.

@w0rk3r w0rk3r added Rule: Tuning tweaking or tuning an existing rule OS: Windows windows related rules Domain: Endpoint backport: auto labels Aug 27, 2024
@w0rk3r w0rk3r self-assigned this Aug 27, 2024
@protectionsmachine
Copy link
Collaborator

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

@w0rk3r
Copy link
Contributor Author

w0rk3r commented Oct 11, 2024

Merging those with min_stack to unblock other 3rd party EDR work.

@w0rk3r w0rk3r merged commit f021229 into main Oct 11, 2024
9 checks passed
@w0rk3r w0rk3r deleted the 3rd_compat_3 branch October 11, 2024 16:33
protectionsmachine pushed a commit that referenced this pull request Oct 11, 2024
@w0rk3r @github-actions
[Rule Tuning] 3rd Party EDR Compatibility - 4 (#4021)
b0bff2f 
* [Rule Tuning] 3rd Party EDR Compatibility - 4

* Update defense_evasion_delete_volume_usn_journal_with_fsutil.toml

* bump updated_date to 8.16 release date

* min_stack for merge, bump updated_date

Removed changes from:
- rules/windows/defense_evasion_create_mod_root_certificate.toml
- rules/windows/defense_evasion_defender_exclusion_via_powershell.toml
- rules/windows/defense_evasion_delete_volume_usn_journal_with_fsutil.toml
- rules/windows/defense_evasion_disable_nla.toml
- rules/windows/defense_evasion_disable_posh_scriptblocklogging.toml
- rules/windows/defense_evasion_disable_windows_firewall_rules_with_netsh.toml
- rules/windows/defense_evasion_disabling_windows_defender_powershell.toml
- rules/windows/defense_evasion_disabling_windows_logs.toml
- rules/windows/defense_evasion_dns_over_https_enabled.toml

(selectively cherry picked from commit f021229)
protectionsmachine pushed a commit that referenced this pull request Oct 11, 2024
@w0rk3r @github-actions
[Rule Tuning] 3rd Party EDR Compatibility - 4 (#4021)
e3b6b19 
* [Rule Tuning] 3rd Party EDR Compatibility - 4

* Update defense_evasion_delete_volume_usn_journal_with_fsutil.toml

* bump updated_date to 8.16 release date

* min_stack for merge, bump updated_date

Removed changes from:
- rules/windows/defense_evasion_create_mod_root_certificate.toml
- rules/windows/defense_evasion_defender_exclusion_via_powershell.toml
- rules/windows/defense_evasion_delete_volume_usn_journal_with_fsutil.toml
- rules/windows/defense_evasion_disable_nla.toml
- rules/windows/defense_evasion_disable_posh_scriptblocklogging.toml
- rules/windows/defense_evasion_disable_windows_firewall_rules_with_netsh.toml
- rules/windows/defense_evasion_disabling_windows_defender_powershell.toml
- rules/windows/defense_evasion_disabling_windows_logs.toml
- rules/windows/defense_evasion_dns_over_https_enabled.toml

(selectively cherry picked from commit f021229)
protectionsmachine pushed a commit that referenced this pull request Oct 11, 2024
@w0rk3r @github-actions
[Rule Tuning] 3rd Party EDR Compatibility - 4 (#4021)
792bbb9 
* [Rule Tuning] 3rd Party EDR Compatibility - 4

* Update defense_evasion_delete_volume_usn_journal_with_fsutil.toml

* bump updated_date to 8.16 release date

* min_stack for merge, bump updated_date

Removed changes from:
- rules/windows/defense_evasion_create_mod_root_certificate.toml
- rules/windows/defense_evasion_defender_exclusion_via_powershell.toml
- rules/windows/defense_evasion_delete_volume_usn_journal_with_fsutil.toml
- rules/windows/defense_evasion_disable_nla.toml
- rules/windows/defense_evasion_disable_posh_scriptblocklogging.toml
- rules/windows/defense_evasion_disable_windows_firewall_rules_with_netsh.toml
- rules/windows/defense_evasion_disabling_windows_defender_powershell.toml
- rules/windows/defense_evasion_disabling_windows_logs.toml
- rules/windows/defense_evasion_dns_over_https_enabled.toml

(selectively cherry picked from commit f021229)
protectionsmachine pushed a commit that referenced this pull request Oct 11, 2024
@w0rk3r @github-actions
[Rule Tuning] 3rd Party EDR Compatibility - 4 (#4021)
cf069e2 
* [Rule Tuning] 3rd Party EDR Compatibility - 4

* Update defense_evasion_delete_volume_usn_journal_with_fsutil.toml

* bump updated_date to 8.16 release date

* min_stack for merge, bump updated_date

(cherry picked from commit f021229)
protectionsmachine pushed a commit that referenced this pull request Oct 11, 2024
@w0rk3r @github-actions
[Rule Tuning] 3rd Party EDR Compatibility - 4 (#4021)
872963a 
* [Rule Tuning] 3rd Party EDR Compatibility - 4

* Update defense_evasion_delete_volume_usn_journal_with_fsutil.toml

* bump updated_date to 8.16 release date

* min_stack for merge, bump updated_date

(cherry picked from commit f021229)
protectionsmachine pushed a commit that referenced this pull request Oct 11, 2024
@w0rk3r @github-actions
[Rule Tuning] 3rd Party EDR Compatibility - 4 (#4021)
3ba7634 
* [Rule Tuning] 3rd Party EDR Compatibility - 4

* Update defense_evasion_delete_volume_usn_journal_with_fsutil.toml

* bump updated_date to 8.16 release date

* min_stack for merge, bump updated_date

(cherry picked from commit f021229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrancedejesus terrancedejesus terrancedejesus approved these changes

@shashank-elastic shashank-elastic shashank-elastic approved these changes

@Aegrah Aegrah Aegrah approved these changes

@Samirbous Samirbous Samirbous approved these changes

@Mikaayenson Mikaayenson Awaiting requested review from Mikaayenson

Assignees

@w0rk3r w0rk3r

Labels
backport: auto Domain: Endpoint OS: Windows windows related rules Rule: Tuning tweaking or tuning an existing rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@w0rk3r @protectionsmachine @Samirbous @Aegrah @shashank-elastic @terrancedejesus