Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Tuning] Tuning Process Termination followed by Deletion #4173

Merged

Conversation

terrancedejesus
Copy link
Contributor

@terrancedejesus terrancedejesus commented Oct 18, 2024

Pull Request

Issue link(s):

Summary - What I changed

Adding process and file exclusions from this rule as listed below. Potentially more to come pending review from @Samirbous and @w0rk3r.

  • Postillion Office by ACI Worldwide --> Ignoring this process executable deletion in file and process events
  • Chocolatey --> Ignoring executables managed by Chocolatey

How To Test

Checklist

  • Added a label for the type of pr: bug, enhancement, schema, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
  • Added the meta:rapid-merge label if planning to merge within 24 hours
  • Secret and sensitive material has been managed correctly
  • Automated testing was updated or added to match the most common scenarios
  • Documentation and comments were added for features that require explanation

Contributor checklist

@terrancedejesus terrancedejesus added Rule: Tuning tweaking or tuning an existing rule OS: Windows windows related rules labels Oct 18, 2024
@protectionsmachine
Copy link
Collaborator

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

@w0rk3r w0rk3r marked this pull request as ready for review November 4, 2024 21:57
@w0rk3r
Copy link
Contributor

w0rk3r commented Nov 4, 2024

Added a few more exclusions based on customer's feedback

@w0rk3r w0rk3r requested review from Samirbous and Aegrah November 4, 2024 21:57
@w0rk3r w0rk3r merged commit 33d832d into main Nov 8, 2024
9 checks passed
@w0rk3r w0rk3r deleted the rule-tuning-windows-process-termination-followed-by-deletion branch November 8, 2024 19:38
protectionsmachine pushed a commit that referenced this pull request Nov 8, 2024
* adding rule tuning

* adjusted operators; fixed missing quotes

* Update rules/windows/defense_evasion_process_termination_followed_by_deletion.toml

* Update defense_evasion_process_termination_followed_by_deletion.toml

* Update defense_evasion_process_termination_followed_by_deletion.toml

---------

Co-authored-by: Samirbous <[email protected]>
Co-authored-by: Jonhnathan <[email protected]>

(cherry picked from commit 33d832d)
protectionsmachine pushed a commit that referenced this pull request Nov 8, 2024
* adding rule tuning

* adjusted operators; fixed missing quotes

* Update rules/windows/defense_evasion_process_termination_followed_by_deletion.toml

* Update defense_evasion_process_termination_followed_by_deletion.toml

* Update defense_evasion_process_termination_followed_by_deletion.toml

---------

Co-authored-by: Samirbous <[email protected]>
Co-authored-by: Jonhnathan <[email protected]>

(cherry picked from commit 33d832d)
protectionsmachine pushed a commit that referenced this pull request Nov 8, 2024
* adding rule tuning

* adjusted operators; fixed missing quotes

* Update rules/windows/defense_evasion_process_termination_followed_by_deletion.toml

* Update defense_evasion_process_termination_followed_by_deletion.toml

* Update defense_evasion_process_termination_followed_by_deletion.toml

---------

Co-authored-by: Samirbous <[email protected]>
Co-authored-by: Jonhnathan <[email protected]>

(cherry picked from commit 33d832d)
protectionsmachine pushed a commit that referenced this pull request Nov 8, 2024
* adding rule tuning

* adjusted operators; fixed missing quotes

* Update rules/windows/defense_evasion_process_termination_followed_by_deletion.toml

* Update defense_evasion_process_termination_followed_by_deletion.toml

* Update defense_evasion_process_termination_followed_by_deletion.toml

---------

Co-authored-by: Samirbous <[email protected]>
Co-authored-by: Jonhnathan <[email protected]>

(cherry picked from commit 33d832d)
protectionsmachine pushed a commit that referenced this pull request Nov 8, 2024
* adding rule tuning

* adjusted operators; fixed missing quotes

* Update rules/windows/defense_evasion_process_termination_followed_by_deletion.toml

* Update defense_evasion_process_termination_followed_by_deletion.toml

* Update defense_evasion_process_termination_followed_by_deletion.toml

---------

Co-authored-by: Samirbous <[email protected]>
Co-authored-by: Jonhnathan <[email protected]>

(cherry picked from commit 33d832d)
protectionsmachine pushed a commit that referenced this pull request Nov 8, 2024
* adding rule tuning

* adjusted operators; fixed missing quotes

* Update rules/windows/defense_evasion_process_termination_followed_by_deletion.toml

* Update defense_evasion_process_termination_followed_by_deletion.toml

* Update defense_evasion_process_termination_followed_by_deletion.toml

---------

Co-authored-by: Samirbous <[email protected]>
Co-authored-by: Jonhnathan <[email protected]>

(cherry picked from commit 33d832d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: auto Domain: Endpoint OS: Windows windows related rules Rule: Tuning tweaking or tuning an existing rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants