Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elastic docs v3 edits #259

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Elastic docs v3 edits #259

merged 5 commits into from
Jan 17, 2025
+15 −13

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 16, 2025

These are pretty minor edits and additions.

@lcawl lcawl added the documentation Improvements or additions to documentation label Jan 16, 2025
Mpdreamz
Mpdreamz requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @lcawl :)

This introduced one warning:

https://github.com/elastic/docs-builder/pull/259/files#annotation_30973449128

🤞 the warning is enough to be able to fix it :)

@lcawl
Copy link
Contributor Author

lcawl commented Jan 17, 2025

🤞 the warning is enough to be able to fix it :)

Thanks, that totally made sense.

@lcawl lcawl merged commit 904211a into main Jan 17, 2025
4 checks passed
@lcawl lcawl deleted the edits branch January 17, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz requested changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @Mpdreamz