New "safe" preview deployment workflows #406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The current preview deployment workflow required
pull_request_target
to be able to deploy PRs from forks.Using
pull_request_target
in conjunction with checking out the fork is considered a security risk.Changes
This introduces a workflow setup that requires three workflows.
pull_request
event and uploads it as artifactsworkflow_run
eventpull_request_target
event (but without a checkout step)This way untrusted code will never be checked out.