-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs migration] Cleans up investigation tools files - pt 1 #498
Conversation
…/docs-content into rip-serverless-files-pt3
Had to re-add the following svg files because they were still being referenced in other raw migrated Serverless files.
Commenting these refs out might be a temporary workaround. Another option is to remove the images in a separate PR. In any case, we should only delete these images after we delete the raw migrated files that contain references to them. |
…/docs-content into rip-serverless-files-pt3
…/docs-content into rip-serverless-files-pt3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I noticed that inline images are displayed on a separate line – I think that might be a wider issue since it's the same in the internal docs.
solutions/security/investigate/run-osquery-from-investigation-guides.md
Outdated
Show resolved
Hide resolved
…guides.md Co-authored-by: natasha-moore-elastic <[email protected]>
It's a wider issue -- it appears across all of the pages that I've updated so far. I'll bring this up the V3 docs channel when I have a chance today. |
Addresses part of #559 by doing the following:
NOTE: With the exception of the Timeline page, I'm using this PR to remove raw migrated serverless files only. After all of the my pages have been properly aligned and version, I'll create a follow-up PR to remove the remaining serverless images that we're no longer using.
Affected pages: