Update golang Docker tag to v1.23.0 (#255)

Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
Co-authored-by: Thibault Richard <[email protected]>

.buildkite/pipeline.yml

@@ -7,14 +7,14 @@ steps:
   - label: ":go: lint"
     command: make lint
     agents:
-      image: "golang:1.22.5"
+      image: "golang:1.23.0"
       cpu: "4"
       memory: "8G"
 
   - label: ":go: tests"
     command: make unit-tests
     agents:
-      image: "golang:1.22.5"
+      image: "golang:1.23.0"
       cpu: "4"
       memory: "4G"
 

.golangci.yml

@@ -22,7 +22,6 @@ linters:
     - cyclop
     - depguard
     - dupl
-    - exhaustivestruct
     - forbidigo
     - funlen
     - gci
@@ -32,14 +31,11 @@ linters:
     - gocyclo
     - godot
     - godox
-    - goerr113
+    - err113
     - gofmt
     - gofumpt
-    - golint
     - gomnd
     - gomodguard
-    - interfacer
-    - maligned
     - nlreturn
     - paralleltest
     - rowserrcheck
@@ -52,13 +48,12 @@ linters:
   enable:
     - asciicheck
     - bodyclose
-    - deadcode
     - dogsled
     - durationcheck
     - errcheck
     - errorlint
     - exhaustive
-    - exportloopref
+    - copyloopvar
     - forcetypeassert
     - gocritic
     - goheader
@@ -80,14 +75,12 @@ linters:
     - predeclared
     - revive
     - staticcheck
-    - structcheck
     - thelper
     - tparallel
     - typecheck
     - unconvert
     - unparam
     - unused
-    - varcheck
     - wastedassign
     - whitespace
 

Makefile

@@ -55,4 +55,4 @@ $(GOBIN)/go-licence-detector:
 	@ go install go.elastic.co/[email protected]
 
 $(GOBIN)/golangci-lint:
-	@ go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.53.2
+	@ go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.60.3

cmd/main.go

@@ -34,7 +34,7 @@ func main() {
 		Long:    "Dump ECK and Kubernetes data for support and troubleshooting purposes.",
 		PreRunE: preRunOperations,
 		Version: internal.Version(),
-		RunE: func(_ *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, _ []string) error {
 			return internal.Run(diagParams)
 		},
 	}

internal/diag.go

@@ -129,7 +129,7 @@ func Run(params Params) error {
 		operatorVersions = append(operatorVersions, detectECKVersion(clientSet, ns, params.ECKVersion))
 	}
 
-	maxOperatorVersion := max(operatorVersions)
+	maxOperatorVersion := maxVersion(operatorVersions)
 	logVersion(maxOperatorVersion)
 
 	allNamespaces := sets.New(params.ResourcesNamespaces...)

internal/version.go

@@ -99,7 +99,7 @@ func extractVersionFromContainers(containers []corev1.Container) *version.Versio
 		if strings.Contains(container.Image, "eck-operator") {
 			parsed, err := extractVersionFromDockerImage(container.Image)
 			if err != nil {
-				logger.Printf(err.Error())
+				logger.Print(err.Error())
 				return fallbackMaxVersion
 			}
 			return parsed
@@ -142,8 +142,8 @@ func extractVersionFromDockerImage(image string) (*version.Version, error) {
 	return fallbackMaxVersion, nil
 }
 
-// max returns the maximum of the given versions.
-func max(versions []*version.Version) *version.Version {
+// maxVersion returns the maximum of the given versions.
+func maxVersion(versions []*version.Version) *version.Version {
 	if len(versions) == 0 {
 		return fallbackMaxVersion
 	}

internal/version_test.go

@@ -50,7 +50,7 @@ func Test_min(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			if got := max(tt.args.versions); !reflect.DeepEqual(got, tt.want) {
+			if got := maxVersion(tt.args.versions); !reflect.DeepEqual(got, tt.want) {
 				t.Errorf("max() = %v, want %v", got, tt.want)
 			}
 		})