Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest ingest libraries #371

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Update to latest ingest libraries #371

merged 1 commit into from
Apr 10, 2024

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Apr 10, 2024

This brings in the latest improvements from https://github.com/elastic/elastic-ingest-dotnet

elastic/elastic-ingest-dotnet#53
elastic/elastic-ingest-dotnet#52

Ensure we act way nicer when logging in a very tight loop.

image image

This fixes #341

As noted on: elastic/elastic-ingest-dotnet#54 (comment)

The defaults scenarios still have 'high' gen2 allocations but they are all owned by the TlsOverPerCoreLockedStacksArrayPool backing the System.Channels BoundedBuffer.

Unsure if there is anything we can do to control it.

See e.g this proposal to .NET dotnet/runtime#53895

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz mentioned this pull request Apr 10, 2024
@Mpdreamz Mpdreamz merged commit 2034617 into main Apr 10, 2024
5 checks passed
@Mpdreamz Mpdreamz deleted the update/ingest branch April 10, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Memory leak
2 participants