mapstr: fix M.Clone behaviour for arrays of M #262
+39
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current implementation does not clone in branches of slices in a mapstr.M, resulting in cases where the clone will share values with the original and allowing unexpected mutation of the original. This change fixes that by adding slices type handling. Note that this will not fix cases of unexpected sharing where the node value type is not a mapstr.M or map[string]any, so structs that are included with pointer fields will still show this effect.
Why is it important?
The current implementation results in data corruption when logging mapstr.M values with redacted fields.
Checklist
Author's Checklist
Related issues