fix(otel-node): fix types for nestjs core instrumentation #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentm
requested changes
Feb 6, 2025
| @@ -50,7 +50,7 @@ | |||
| * "@opentelemetry/instrumentation-mongoose": import('@opentelemetry/instrumentation-mongoose').MongooseInstrumentationConfig | InstrumentationFactory, | |||
| * "@opentelemetry/instrumentation-mysql": import('@opentelemetry/instrumentation-mysql').MySQLInstrumentation | InstrumentationFactory, | |||
| * "@opentelemetry/instrumentation-mysql2": import('@opentelemetry/instrumentation-mysql2').MySQL2Instrumentation | InstrumentationFactory, | |||
| * "@opentelemetry/instrumentation-nestjs-core": import('@opentelemetry/instrumentation').InstrumentationConfig | InstrumentationFactory, | |||
| * "@opentelemetry/instrumentation-nestjs-core": import('@opentelemetry/instrumentation-nestjs-core').NestInstrumentation | InstrumentationFactory, | |||
There was a problem hiding this comment.
That doesn't seem right. This should be the config type that the instrumentations takes to its constructor.
The NestInstrumentation doesn't take any special config: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/4560d144ced8b758395003966028fbf090065105/plugins/node/opentelemetry-instrumentation-nestjs-core/src/instrumentation.ts#L45-L47
There was a problem hiding this comment.
Good catch! So this is not needed. Closing then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#558 was created to add this instrumentation but it turns out it was already added in f5a0656. This PR just fixes the types of the configurations map.
Adding a test case was considered an tried locally but it is too much effort since it requires to have a specific setup for it (NestJS project, install dependencies, run the project and mockotlpserver at the same time, etc.).
runTestFixturesis not enough and create something just for 1 instrumentation just feels too muchCloses: #558