Instantiate runners directly on test commands #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
changed the title
mrodm
commented
Jun 5, 2024
mrodm
force-pushed
the
call_runners_from_command
branch
from
3471042 to
e5002af
Compare
jsoriano
approved these changes
Jun 6, 2024
| runner := asset.NewAssetRunner(asset.AssetRunnerOptions{ | ||
| TestFolder: testrunner.TestFolder{Package: pkg}, | ||
| PackageRootPath: packageRootPath, | ||
| KibanaClient: kibanaClient, |
There was a problem hiding this comment.
Good to have specific option types 👍
💚 Build Succeeded
History
cc @mrodm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #787
Follows #1886
This PR instantiates in each command the corresponding runner, for that new constructors have been added into each runner. This allows us to create independent Options structs for each runner with just the required options for each runner.
These changes allow to remove the registry of the runners.
For now, it is kept the TestRunner interface since that will force to define Run and TearDown methods so they can be used in
testrunner.Run()