This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Fix pronoun #780
Open
Fix pronoun #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanullah92
reviewed
Sep 25, 2018
| @@ -3,7 +3,7 @@ | |||
| Elasticsearch ships with _very good_ defaults,((("deployment", "configuration changes, important")))((("configuration changes, important"))) especially when it comes to performance- | |||
| related settings and options. When in doubt, just leave | |||
| the settings alone. We have witnessed countless dozens of clusters ruined | |||
| by errant settings because the administrator thought he could turn a knob | |||
| by errant settings because the administrator thought they could turn a knob | |||
There was a problem hiding this comment.
Perhaps he/she would be better. "they" specifies plural, so it will go with "administrators" rather. Current state is okay IMO.
There was a problem hiding this comment.
'they' as a gener-neutral singular pronoun is grammatically correct https://en.wikipedia.org/wiki/Singular_they
There was a problem hiding this comment.
Okay, great then. Wasn't aware of such a usage. (y)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.