Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing autoscaling timeout parameters #3162

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

pquentin
Copy link
Member

In elastic/elasticsearch#108759, @DaveCTurner added master_timeout support for autoscaling APIs. We were also already misssing timeout parameters. Note that adding those entries removes all the autoscaling entries in output/schema/validation-errors.json.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
autoscaling.delete_autoscaling_policy Missing test Missing test
autoscaling.get_autoscaling_capacity Missing test Missing test
autoscaling.get_autoscaling_policy Missing test Missing test
autoscaling.put_autoscaling_policy Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pquentin pquentin merged commit 1afed69 into main Nov 21, 2024
9 checks passed
@pquentin pquentin deleted the autoscaling-timeouts branch November 21, 2024 16:57
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants