Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the index version compatible test to only check the minimum #120406

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Update the index version compatible test to only check the minimum #120406

merged 3 commits into from
Jan 23, 2025

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Jan 17, 2025

We actually only care about the minimum version here - to ensure that we aren't over or under testing. We don't need to look at every version number.

Fixes #98054

@thecoop thecoop added >test Issues or PRs that are addressing/adding tests :Delivery/Tooling Developer tooliing and automation auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 labels Jan 17, 2025
@thecoop thecoop requested a review from mark-vieira January 17, 2025 15:57
@elasticsearchmachine elasticsearchmachine added the Team:Delivery Meta label for Delivery team label Jan 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@thecoop thecoop added the :Core/Infra/Core Core issues without another label label Jan 17, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jan 17, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

ldematte
ldematte approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think it makes sense to seek for Mark/delivery approval too. Up to you :)

mark-vieira
mark-vieira approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop thecoop merged commit 787a16d into elastic:main Jan 23, 2025
16 checks passed
@thecoop thecoop deleted the fix-index-compatible-check branch January 23, 2025 15:59
thecoop added a commit to thecoop/elasticsearch that referenced this pull request Jan 23, 2025
@thecoop
Update the index version compatible test to only check the minimum (e…
089497a 
…lastic#120406)
@thecoop thecoop mentioned this pull request Jan 23, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.x

elasticsearchmachine pushed a commit that referenced this pull request Jan 23, 2025
@thecoop
Update the index version compatible test to only check the minimum (#…
fa1cac3 
…120406) (#120738)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-vieira mark-vieira mark-vieira approved these changes

@ldematte ldematte ldematte approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Core Core issues without another label :Delivery/Tooling Developer tooliing and automation Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] IndexVersionUtiltsTests testGradleVersionsMatchVersionUtils failing
4 participants
@thecoop @elasticsearchmachine @ldematte @mark-vieira