Counted keyword synthetic source inherit keep #120426
Draft
+701
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 025063f.
jordan-powers
added
>enhancement
auto-backport
elasticsearchmachine
added
the
external-contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism to track the value of the
synthetic_source_keepsetting if it is set in the mapping settings, inherited from an object field at a higher level, or specified in the index settings. This value is then used to properly implement synthetic source support in thecounted_keywordfield type.This PR also adds tests to MapperTestCase to verify that if
synthetic_source_keepis set on an outer object field, or in the index settings, it is respected by mappers.Follow-up to #120078
Relates to #109796