[Nginx] Fix stubstatus benchmark #8914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ingesting data with the `stream` command, the current track failed with the following error:
```
{"errors":true,"took":0,"ingest_took":1,"items":[{"create":{"_index":"metrics-nginx.stubstatus-ep","_id":null,"status":400,"error":{"type":"illegal_argument_exception","reason":"the document timestamp [2024-01-17T13:58:56.000Z] is outside of ranges of currently writable indices [[2024-01-17T10:46:15.000Z,2024-01-17T13:33:47.000Z]]"}}}
```
The reason was, that the timestamp used did not contain any timezone so it was in UTC. TSDB automatically sets up a range based on `now` for the local setup so when you were too far out from UTC ingestion failed. Adding the local timezone to the timezone fixes this and also ensures data that is ingested with `stream` shows up as "current" data in Discover.
To test this, run the following command:
```
elastic-package benchmark stream --benchmark stubstatus-benchmark -v
```
This should also work with the 15min prefill as the timestamp set by TSDB for the first index is in the past.
|
Do we also have to adjust some other benchmark configs with this change in case it is missing in some? |
|
I followed up with elastic/elastic-package#1625 to make these kind of issues easier to debug. |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @ruflin |
Yes I think so this one would be the candidate from at least I raised #8761 |
tommyers-elastic
approved these changes
Jan 17, 2024
|
@aliabbas-elastic Could you do a follow up PR on the ones that uses metrics with the time zone part? |
|
Sure @ruflin I am raising them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ingesting data with the
streamcommand, the current track failed with the following error:The reason was, that the timestamp used did not contain any timezone so it was in UTC. TSDB automatically sets up a range based on
nowfor the local setup so when you were too far out from UTC ingestion failed. Adding the local timezone to the timezone fixes this and also ensures data that is ingested withstreamshows up as "current" data in Discover.To test this, run the following command:
This should also work with the 15min prefill as the timestamp set by TSDB for the first index is in the past.