Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure network watcher packages docker scenario #9940

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented May 22, 2024

Proposed commit message

Update docker scenario for these packages to not use the full service name. Those containers can access the required service just with the service name in the same compose.

This will also help us to update how elastic-package manages these compose scenarios in the context of elastic/elastic-package#787

How to test this PR locally

Run system tests in both packages:

elastic-package stack up -v -d

# test both packages
cd /path/package
elastic-package test system -v

elastic-package stack down

Related issues

@mrodm mrodm self-assigned this May 22, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

cc @mrodm

@mrodm mrodm requested a review from a team May 22, 2024 14:38
@mrodm mrodm marked this pull request as ready for review May 22, 2024 14:38
@mrodm mrodm requested a review from a team as a code owner May 22, 2024 14:38
@mrodm mrodm changed the title Update azure network watche packages docker scenario Update azure network watcher packages docker scenario May 22, 2024
@mrodm mrodm merged commit c9f5774 into elastic:main Jun 3, 2024
5 checks passed
@mrodm mrodm deleted the update-azure-network-watcher-tests branch June 3, 2024 10:39
rcesar99999 pushed a commit to rcesar99999/new_integrations that referenced this pull request Feb 10, 2025
Update docker scenario for these packages to not use the full service name.
Those containers can access the required service just with the service name
defined in the same compose file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants