[8.x] [Search] [Onboarding] unskip FTR tests (#202818) (#203494)

# Backport This will backport the following commits from `main` to `8.x`: - [[Search] [Onboarding] unskip FTR tests (#202818)](#202818)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  --------- Co-authored-by: kibanamachine <[email protected]>
elastic · Dec 9, 2024 · bf2a32b · bf2a32b
1 parent 71bfa26
commit bf2a32b
Show file tree

Hide file tree

Showing 3 changed files with 54 additions and 1 deletion.
diff --git a/x-pack/test_serverless/functional/page_objects/svl_api_keys.ts b/x-pack/test_serverless/functional/page_objects/svl_api_keys.ts
@@ -6,6 +6,7 @@
  */
 
 import expect from '@kbn/expect';
+import { SecurityApiKey } from '@elastic/elasticsearch/lib/api/types';
 import { FtrProviderContext } from '../ftr_provider_context';
 
 const APIKEY_MASK = '•'.repeat(60);
@@ -27,6 +28,10 @@ export function SvlApiKeysProvider({ getService, getPageObjects }: FtrProviderCo
       await browser.clearSessionStorage();
     },
 
+    async expectAPIKeyExists() {
+      await testSubjects.existOrFail('apiKeyFormAPIKey', { timeout: 1000 });
+    },
+
     async expectAPIKeyAvailable() {
       await testSubjects.existOrFail('apiKeyFormAPIKey');
       await retry.try(async () => {
@@ -84,8 +89,19 @@ export function SvlApiKeysProvider({ getService, getPageObjects }: FtrProviderCo
     },
 
     async deleteAPIKeys() {
+      const filterInvalid = (key: SecurityApiKey) => !key.invalidated;
+
       const { api_keys: apiKeys } = await es.security.getApiKey();
-      await es.security.invalidateApiKey({ ids: apiKeys.map((key) => key.id) });
+
+      const validKeys = apiKeys.filter(filterInvalid);
+
+      if (validKeys.length === 0) {
+        return;
+      }
+
+      await es.security.invalidateApiKey({
+        ids: validKeys.map((key) => key.id),
+      });
     },
 
     async expectCreateApiKeyAction() {

diff --git a/x-pack/test_serverless/functional/test_suites/search/elasticsearch_start.ts b/x-pack/test_serverless/functional/test_suites/search/elasticsearch_start.ts
@@ -21,6 +21,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
   const esDeleteAllIndices = getService('esDeleteAllIndices');
   const es = getService('es');
   const browser = getService('browser');
+  const retry = getService('retry');
 
   const deleteAllTestIndices = async () => {
     await esDeleteAllIndices(['search-*', 'test-*']);
@@ -95,7 +96,20 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
       it('should show the api key in code view', async () => {
         await pageObjects.svlSearchElasticsearchStartPage.expectToBeOnStartPage();
         await pageObjects.svlSearchElasticsearchStartPage.clickCodeViewButton();
+        // sometimes the API key exists in the cluster and its lost in sessionStorage
+        // if fails we retry to delete the API key and refresh the browser
+        await retry.try(
+          async () => {
+            await pageObjects.svlApiKeys.expectAPIKeyExists();
+          },
+          async () => {
+            await pageObjects.svlApiKeys.deleteAPIKeys();
+            await browser.refresh();
+            await pageObjects.svlSearchElasticsearchStartPage.clickCodeViewButton();
+          }
+        );
         await pageObjects.svlApiKeys.expectAPIKeyAvailable();
+
         const apiKeyUI = await pageObjects.svlApiKeys.getAPIKeyFromUI();
         const apiKeySession = await pageObjects.svlApiKeys.getAPIKeyFromSessionStorage();
 

diff --git a/x-pack/test_serverless/functional/test_suites/search/search_index_detail.ts b/x-pack/test_serverless/functional/test_suites/search/search_index_detail.ts
@@ -20,6 +20,8 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
   const svlSearchNavigation = getService('svlSearchNavigation');
   const es = getService('es');
   const security = getService('security');
+  const browser = getService('browser');
+  const retry = getService('retry');
 
   const esDeleteAllIndices = getService('esDeleteAllIndices');
   const indexName = 'test-my-index';
@@ -89,6 +91,27 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
         await svlSearchNavigation.navigateToIndexDetailPage(indexName);
       });
 
+      describe('API key details', () => {
+        it('should show api key', async () => {
+          await pageObjects.svlApiKeys.deleteAPIKeys();
+          await svlSearchNavigation.navigateToIndexDetailPage(indexName);
+          // sometimes the API key exists in the cluster and its lost in sessionStorage
+          // if fails we retry to delete the API key and refresh the browser
+          await retry.try(
+            async () => {
+              await pageObjects.svlApiKeys.expectAPIKeyExists();
+            },
+            async () => {
+              await pageObjects.svlApiKeys.deleteAPIKeys();
+              await browser.refresh();
+            }
+          );
+          await pageObjects.svlApiKeys.expectAPIKeyAvailable();
+          const apiKey = await pageObjects.svlApiKeys.getAPIKeyFromUI();
+          await pageObjects.svlSearchIndexDetailPage.expectAPIKeyToBeVisibleInCodeBlock(apiKey);
+        });
+      });
+
       it('should show code examples for adding documents', async () => {
         await pageObjects.svlSearchIndexDetailPage.expectAddDocumentCodeExamples();
         await pageObjects.svlSearchIndexDetailPage.expectSelectedLanguage('python');